Fix SSPI user creation (#28948)

Fixes #28945

Setting the avatar is wrong and creating a random password is equal to
leave it empty.

diff --git a/services/auth/sspi.go b/services/auth/sspi.go
index 57ba0462c573bebb529512bf319c8a083de0f866..0e974fde8f3585de4aa7e725f433745afe0e7ba7 100644 (file)
--- a/services/auth/sspi.go
+++ b/services/auth/sspi.go
@@ -11,7 +11,6 @@ import (
        "sync"
 
        "code.gitea.io/gitea/models/auth"
-       "code.gitea.io/gitea/models/avatars"
        "code.gitea.io/gitea/models/db"
        user_model "code.gitea.io/gitea/models/user"
        "code.gitea.io/gitea/modules/base"
@@ -167,12 +166,9 @@ func (s *SSPI) shouldAuthenticate(req *http.Request) (shouldAuth bool) {
 func (s *SSPI) newUser(ctx context.Context, username string, cfg *sspi.Source) (*user_model.User, error) {
        email := gouuid.New().String() + "@localhost.localdomain"
        user := &user_model.User{
-               Name:            username,
-               Email:           email,
-               Passwd:          gouuid.New().String(),
-               Language:        cfg.DefaultLanguage,
-               UseCustomAvatar: true,
-               Avatar:          avatars.DefaultAvatarLink(),
+               Name:     username,
+               Email:    email,
+               Language: cfg.DefaultLanguage,
        }
        emailNotificationPreference := user_model.EmailNotificationsDisabled
        overwriteDefault := &user_model.CreateUserOverwriteOptions{