replace some calls to Collection methods with shorter/more effective versions

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1874263 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/src/java/org/apache/poi/poifs/filesystem/POIFSDocument.java b/src/java/org/apache/poi/poifs/filesystem/POIFSDocument.java
index e43029d459b9c782239397ae936ad3c443d6854f..05881561b1283698754058a2c775822ffa9b5a9b 100644 (file)
--- a/src/java/org/apache/poi/poifs/filesystem/POIFSDocument.java
+++ b/src/java/org/apache/poi/poifs/filesystem/POIFSDocument.java
@@ -17,7 +17,7 @@
 
 package org.apache.poi.poifs.filesystem;
 
-import static java.util.Collections.emptyList;
+import static java.util.Collections.emptyIterator;
 
 import java.io.BufferedInputStream;
 import java.io.IOException;
@@ -235,7 +235,7 @@ public final class POIFSDocument implements POIFSViewable, Iterable<ByteBuffer>
     *           store
     */
    public Iterator<Object> getViewableIterator() {
-      return emptyList().iterator();
+      return emptyIterator();
    }
 
    /**

diff --git a/src/java/org/apache/poi/poifs/filesystem/POIFSFileSystem.java b/src/java/org/apache/poi/poifs/filesystem/POIFSFileSystem.java
index 12e408ee6346862aad81b7ee2b47b1f1f3c1529c..23d9b3e2b07edfdab54f2d62d1ad4ba310de5dd3 100644 (file)
--- a/src/java/org/apache/poi/poifs/filesystem/POIFSFileSystem.java
+++ b/src/java/org/apache/poi/poifs/filesystem/POIFSFileSystem.java
@@ -858,7 +858,7 @@ public class POIFSFileSystem extends BlockStore
             return getRoot().getViewableIterator();
         }
 
-        return Collections.emptyList().iterator();
+        return Collections.emptyIterator();
     }
 
     /**

diff --git a/src/java/org/apache/poi/poifs/property/Property.java b/src/java/org/apache/poi/poifs/property/Property.java
index 59727a3584058ddea2853188c4e7749bf8457935..a994ff133b3b60839fb73c527ea8744b0f4adfda 100644 (file)
--- a/src/java/org/apache/poi/poifs/property/Property.java
+++ b/src/java/org/apache/poi/poifs/property/Property.java
@@ -500,7 +500,7 @@ public abstract class Property implements Child, POIFSViewable {
      */
     public Iterator<Object> getViewableIterator()
     {
-        return Collections.emptyList().iterator();
+        return Collections.emptyIterator();
     }
 
     /**

diff --git a/src/ooxml/java/org/apache/poi/openxml4j/opc/internal/ContentTypeManager.java b/src/ooxml/java/org/apache/poi/openxml4j/opc/internal/ContentTypeManager.java
index 4ca6189955e2d164d10e5c305f1c8eed8f7d2fc5..5b356843c8638f4315d4deab44930313c3f0dd28 100644 (file)
--- a/src/ooxml/java/org/apache/poi/openxml4j/opc/internal/ContentTypeManager.java
+++ b/src/ooxml/java/org/apache/poi/openxml4j/opc/internal/ContentTypeManager.java
@@ -286,8 +286,8 @@ public abstract class ContentTypeManager {
             throw new IllegalArgumentException("contentType");
         }
 
-        return (this.defaultContentType.values().contains(contentType) || (this.overrideContentType != null && this.overrideContentType
-                .values().contains(contentType)));
+        return (this.defaultContentType.containsValue(contentType) || 
+                (this.overrideContentType != null && this.overrideContentType.containsValue(contentType)));
     }
 
     /**