]> source.dussan.org Git - jquery.git/commitdiff
Fixed #1781 for warnings created on load by FF javascript.options.strict == true.
authorDavid Serduke <davidserduke@gmail.com>
Sun, 16 Dec 2007 01:03:50 +0000 (01:03 +0000)
committerDavid Serduke <davidserduke@gmail.com>
Sun, 16 Dec 2007 01:03:50 +0000 (01:03 +0000)
src/ajax.js
src/core.js
src/event.js
src/fx.js
src/offset.js

index 01ee877327479c17f0e37d059e32cdece89ec163..6628b1f3977ab8ad963c7b526318434ed861f6b6 100644 (file)
@@ -246,7 +246,7 @@ jQuery.extend({
                        head.appendChild(script);
 
                        // We handle everything using the script element injection
-                       return;
+                       return undefined;
                }
 
                var requestDone = false;
@@ -361,9 +361,6 @@ jQuery.extend({
                // firefox 1.5 doesn't fire statechange for sync requests
                if ( !s.async )
                        onreadystatechange();
-               
-               // return XMLHttpRequest to allow aborting the request etc.
-               return xml;
 
                function success(){
                        // If a local callback was specified, fire it and pass it the data
@@ -388,6 +385,9 @@ jQuery.extend({
                        if ( s.global && ! --jQuery.active )
                                jQuery.event.trigger( "ajaxStop" );
                }
+               
+               // return XMLHttpRequest to allow aborting the request etc.
+               return xml;
        },
 
        handleError: function( s, xml, status, e ) {
index 6e1ed9e956d6ba2a76f5ceae2d002426269946e4..7ac4ad75b85a7ef4b570dd2dcfd0443f023198ef 100644 (file)
@@ -418,31 +418,32 @@ jQuery.fn = jQuery.prototype = {
 
                        }
 
-               } else
-                       return this.each(function(){
-                               if ( this.nodeType != 1 )
-                                       return;
+               }
+
+               return this.each(function(){
+                       if ( this.nodeType != 1 )
+                               return;
 
-                               if ( value.constructor == Array && /radio|checkbox/.test( this.type ) )
-                                       this.checked = (jQuery.inArray(this.value, value) >= 0 ||
-                                               jQuery.inArray(this.name, value) >= 0);
+                       if ( value.constructor == Array && /radio|checkbox/.test( this.type ) )
+                               this.checked = (jQuery.inArray(this.value, value) >= 0 ||
+                                       jQuery.inArray(this.name, value) >= 0);
 
-                               else if ( jQuery.nodeName( this, "select" ) ) {
-                                       var values = value.constructor == Array ?
-                                               value :
-                                               [ value ];
+                       else if ( jQuery.nodeName( this, "select" ) ) {
+                               var values = value.constructor == Array ?
+                                       value :
+                                       [ value ];
 
-                                       jQuery( "option", this ).each(function(){
-                                               this.selected = (jQuery.inArray( this.value, values ) >= 0 ||
-                                                       jQuery.inArray( this.text, values ) >= 0);
-                                       });
+                               jQuery( "option", this ).each(function(){
+                                       this.selected = (jQuery.inArray( this.value, values ) >= 0 ||
+                                               jQuery.inArray( this.text, values ) >= 0);
+                               });
 
-                                       if ( !values.length )
-                                               this.selectedIndex = -1;
+                               if ( !values.length )
+                                       this.selectedIndex = -1;
 
-                               } else
-                                       this.value = value;
-                       });
+                       } else
+                               this.value = value;
+               });
        },
        
        html: function( value ) {
@@ -971,9 +972,9 @@ jQuery.extend({
                                                        div.childNodes :
                                                        [];
                                
-                                       for ( var i = tbody.length - 1; i >= 0 ; --i )
-                                               if ( jQuery.nodeName( tbody[ i ], "tbody" ) && !tbody[ i ].childNodes.length )
-                                                       tbody[ i ].parentNode.removeChild( tbody[ i ] );
+                                       for ( var j = tbody.length - 1; j >= 0 ; --j )
+                                               if ( jQuery.nodeName( tbody[ j ], "tbody" ) && !tbody[ j ].childNodes.length )
+                                                       tbody[ j ].parentNode.removeChild( tbody[ j ] );
                                        
                                        // IE completely kills leading whitespace when innerHTML is used        
                                        if ( /^\s/.test( elem ) )       
index cc3338b02a1ef4401278fd2a53bc72222fcc28ba..904c671d0d746e1de772c159874f22491af1d96a 100644 (file)
@@ -170,7 +170,7 @@ jQuery.event = {
                } else {
                        // don't do events on text and comment nodes
                        if ( element.nodeType == 3 || element.nodeType == 8 )
-                               return;
+                               return undefined;
 
                        var val, ret, fn = jQuery.isFunction( element[ type ] || null ),
                                // Check to see if we need to provide a fake event, or not
@@ -332,14 +332,15 @@ jQuery.event = {
        
                                // If Safari or IE is used
                                // Continually check to see if the document is ready
-                               if  (jQuery.browser.msie || jQuery.browser.safari ) (function(){
+                               if (jQuery.browser.msie || jQuery.browser.safari ) (function(){
                                        try {
                                                // If IE is used, use the trick by Diego Perini
                                                // http://javascript.nwbox.com/IEContentLoaded/
                                                if ( jQuery.browser.msie || document.readyState != "loaded" && document.readyState != "complete" )
                                                        document.documentElement.doScroll("left");
                                        } catch( error ) {
-                                               return setTimeout( arguments.callee, 0 );
+                                               setTimeout( arguments.callee, 0 );
+                                               return;
                                        }
 
                                        // and execute any waiting functions
@@ -367,17 +368,19 @@ jQuery.event = {
                        setup: function() {
                                if (jQuery.browser.msie) return false;
                                jQuery(this).bind('mouseover', jQuery.event.special.mouseenter.handler);
+                               return true;
                        },
                
                        teardown: function() {
                                if (jQuery.browser.msie) return false;
                                jQuery(this).unbind('mouseover', jQuery.event.special.mouseenter.handler);
+                               return true;
                        },
                        
                        handler: function(event) {
                                var args = Array.prototype.slice.call( arguments, 1 );
                                // If we actually just moused on to a sub-element, ignore it
-                               if ( withinElement(event, this) ) return;
+                               if ( withinElement(event, this) ) return true;
                                // Execute the right handlers by setting the event type to mouseenter
                                event.type = 'mouseenter';
                                // Include the event object as the first argument
@@ -391,17 +394,19 @@ jQuery.event = {
                        setup: function() {
                                if (jQuery.browser.msie) return false;
                                jQuery(this).bind('mouseout', jQuery.event.special.mouseleave.handler);
+                               return true;
                        },
                
                        teardown: function() {
                                if (jQuery.browser.msie) return false;
                                jQuery(this).unbind('mouseout', jQuery.event.special.mouseleave.handler);
+                               return true;
                        },
                        
                        handler: function(event) {
                                var args = Array.prototype.slice.call( arguments, 1 );
                                // If we actually just moused on to a sub-element, ignore it
-                               if ( withinElement(event, this) ) return false;
+                               if ( withinElement(event, this) ) return true;
                                // Execute the right handlers by setting the event type to mouseleave
                                event.type = 'mouseleave';
                                // Include the event object as the first argument
@@ -444,6 +449,7 @@ jQuery.fn.extend({
        triggerHandler: function( type, data, fn ) {
                if ( this[0] )
                        return jQuery.event.trigger( type, data, this[0], false, fn );
+               return undefined;
        },
 
        toggle: function() {
index c613f938dad3dbe58fa5ad328067ccc6bb5c2f6e..fb564f07c562c1fdbb2dfc1a3f5e5a22ee75274a 100644 (file)
--- a/src/fx.js
+++ b/src/fx.js
@@ -181,7 +181,7 @@ jQuery.fn.extend({
 
 var queue = function( elem, type, array ) {
        if ( !elem )
-               return;
+               return undefined;
 
        type = type || "fx";
 
@@ -418,4 +418,4 @@ jQuery.fx.step = {
        _default: function(fx){
                fx.elem.style[ fx.prop ] = fx.now + fx.unit;
        }
-};
\ No newline at end of file
+};
index 257035816169df4face0b3c50a289b900850806d..46b971bc9614dc3b16e64d35f3e0992b96e971be 100644 (file)
@@ -85,8 +85,6 @@ jQuery.fn.offset = function() {
                results = { top: top, left: left };
        }
 
-       return results;
-
        function border(elem) {
                add( jQuery.css(elem, "borderLeftWidth"), jQuery.css(elem, "borderTopWidth") );
        }
@@ -95,4 +93,6 @@ jQuery.fn.offset = function() {
                left += parseInt(l) || 0;
                top += parseInt(t) || 0;
        }
+
+       return results;
 };