PushCommand: Set force-update in-place

Rather than copying the entire list, just replace each element
with the version that has setForceUpdate(true) invoked on it.

Change-Id: I2eaa4466d497cb2408ce61dc62ca26e0c32fe841
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>

diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/api/PushCommand.java b/org.eclipse.jgit/src/org/eclipse/jgit/api/PushCommand.java
index e8175d0997568c50160d9759b42adb674a667af2..3ceeec42b089e2e118a0cc797e1c91829b14b2b9 100644 (file)
--- a/org.eclipse.jgit/src/org/eclipse/jgit/api/PushCommand.java
+++ b/org.eclipse.jgit/src/org/eclipse/jgit/api/PushCommand.java
@@ -78,7 +78,7 @@ public class PushCommand extends GitCommand<Iterable<PushResult>> {
 
        private String remote = Constants.DEFAULT_REMOTE_NAME;
 
-       private List<RefSpec> refSpecs;
+       private final List<RefSpec> refSpecs;
 
        private ProgressMonitor monitor = NullProgressMonitor.INSTANCE;
 
@@ -124,10 +124,8 @@ public class PushCommand extends GitCommand<Iterable<PushResult>> {
 
                try {
                        if (force) {
-                               final List<RefSpec> orig = new ArrayList<RefSpec>(refSpecs);
-                               refSpecs.clear();
-                               for (final RefSpec spec : orig)
-                                       refSpecs.add(spec.setForceUpdate(true));
+                               for (int i = 0; i < refSpecs.size(); i++)
+                                       refSpecs.set(i, refSpecs.get(i).setForceUpdate(true));
                        }
 
                        final List<Transport> transports;