Merge branch 'stable-4.8' into stable-4.9

* stable-4.8:
  Bazel: Use hyphen instead of underscore in external repository names
  Bazel: Format all build files with buildifier 0.15.0
  ChangeIdUtilTest: Remove unused notestCommitDashV

Change-Id: I17436237cd66ca1c2800ad5ab0142f4a2bc07328
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>

diff --cc WORKSPACE
Simple merge

diff --cc lib/BUILD
Simple merge

diff --cc org.eclipse.jgit.test/tests.bzl
index 637fe0c9c3de485a22be410d8428a22e46b6bf67,8ae0065a4c04037f7bc707a80c59193283303e85..c75ab767670ea0f027647e74a1f8485109b234d0
--- 1/org.eclipse.jgit.test/tests.bzl
--- 2/org.eclipse.jgit.test/tests.bzl
+++ b/org.eclipse.jgit.test/tests.bzl
@@@ -4,53 -4,45 +4,53 @@@ load
  )
  
  def tests(tests):
-   for src in tests:
-     name = src[len('tst/'):len(src)-len('.java')].replace('/', '_')
-     labels = []
-     if name.startswith('org_eclipse_jgit_'):
-       l = name[len('org.eclipse.jgit_'):]
-       if l.startswith('internal_storage_'):
-         l = l[len('internal.storage_'):]
-       i = l.find('_')
-       if i > 0:
-         labels.append(l[:i])
-       else:
-         labels.append(i)
-     if 'lib' not in labels:
-       labels.append('lib')
+     for src in tests:
+         name = src[len("tst/"):len(src) - len(".java")].replace("/", "_")
+         labels = []
+         if name.startswith("org_eclipse_jgit_"):
+             l = name[len("org.eclipse.jgit_"):]
+             if l.startswith("internal_storage_"):
+                 l = l[len("internal.storage_"):]
+             i = l.find("_")
+             if i > 0:
+                 labels.append(l[:i])
+             else:
+                 labels.append(i)
+         if "lib" not in labels:
+             labels.append("lib")
  
-     additional_deps = []
-     if src.endswith("RootLocaleTest.java"):
-       additional_deps = [
-         '//org.eclipse.jgit.pgm:pgm',
-         '//org.eclipse.jgit.ui:ui',
-       ]
-     if src.endswith("WalkEncryptionTest.java"):
-       additional_deps = [
-         '//org.eclipse.jgit:insecure_cipher_factory',
-       ]
-     if src.endswith("OpenSshConfigTest.java"):
-       additional_deps = [
-         '//lib:jsch',
-       ]
-     if src.endswith("JschConfigSessionFactoryTest.java"):
-       additional_deps = [
-         '//lib:jsch',
-       ]
+         additional_deps = []
+         if src.endswith("RootLocaleTest.java"):
+             additional_deps = [
+                 "//org.eclipse.jgit.pgm:pgm",
+                 "//org.eclipse.jgit.ui:ui",
+             ]
+         if src.endswith("WalkEncryptionTest.java"):
+             additional_deps = [
+                 "//org.eclipse.jgit:insecure_cipher_factory",
+             ]
++        if src.endswith("OpenSshConfigTest.java"):
++            additional_deps = [
++                "//lib:jsch",
++            ]
++        if src.endswith("JschConfigSessionFactoryTest.java"):
++            additional_deps = [
++                "//lib:jsch",
++            ]
  
-     junit_tests(
-       name = name,
-       tags = labels,
-       srcs = [src],
-       deps = additional_deps + [
-         ':helpers',
-         ':tst_rsrc',
-         '//lib:javaewah',
-         '//lib:junit',
-         '//lib:slf4j-api',
-         '//org.eclipse.jgit:jgit',
-         '//org.eclipse.jgit.junit:junit',
-         '//org.eclipse.jgit.lfs:jgit-lfs',
-       ],
-       jvm_flags = ["-Xmx256m", "-Dfile.encoding=UTF-8"],
-     )
+         junit_tests(
+             name = name,
+             tags = labels,
+             srcs = [src],
+             deps = additional_deps + [
+                 ":helpers",
+                 ":tst_rsrc",
+                 "//lib:javaewah",
+                 "//lib:junit",
+                 "//lib:slf4j-api",
+                 "//org.eclipse.jgit:jgit",
+                 "//org.eclipse.jgit.junit:junit",
+                 "//org.eclipse.jgit.lfs:jgit-lfs",
+             ],
+             jvm_flags = ["-Xmx256m", "-Dfile.encoding=UTF-8"],
+         )