[infer] Fix resource leak in RepoCommand

Bug: 509385
Change-Id: I30c427f0dd2fc1fceb6b003dfdee0a05efaefca9
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/gitrepo/RepoCommand.java b/org.eclipse.jgit/src/org/eclipse/jgit/gitrepo/RepoCommand.java
index 9b7f094d0f2638451f01233cc29ce74de8df9584..86dbabca0b9c9b61f850b9fe2d8a63e1ffe9e0bd 100644 (file)
--- a/org.eclipse.jgit/src/org/eclipse/jgit/gitrepo/RepoCommand.java
+++ b/org.eclipse.jgit/src/org/eclipse/jgit/gitrepo/RepoCommand.java
@@ -180,17 +180,11 @@ public class RepoCommand extends GitCommand<RevCommit> {
                public byte[] readFile(String uri, String ref, String path)
                                throws GitAPIException, IOException {
                        File dir = FileUtils.createTempDir("jgit_", ".git", null); //$NON-NLS-1$ //$NON-NLS-2$
-                       Repository repo = Git
-                                       .cloneRepository()
-                                       .setBare(true)
-                                       .setDirectory(dir)
-                                       .setURI(uri)
-                                       .call()
-                                       .getRepository();
-                       try {
+                       try (Git git = Git.cloneRepository().setBare(true).setDirectory(dir)
+                                       .setURI(uri).call();
+                                       Repository repo = git.getRepository()) {
                                return readFileFromRepo(repo, ref, path);
                        } finally {
-                               repo.close();
                                FileUtils.delete(dir, FileUtils.RECURSIVE);
                        }
                }