]> source.dussan.org Git - jgit.git/commitdiff
Use the same variable to check and extract LFS object id 71/85671/1
authorJacek Centkowski <geminica.programs@gmail.com>
Thu, 24 Nov 2016 10:32:48 +0000 (11:32 +0100)
committerJacek Centkowski <geminica.programs@gmail.com>
Thu, 24 Nov 2016 10:32:48 +0000 (11:32 +0100)
It is easier to maintain when the same variable is used for both check
and extraction of LFS object id.

Change-Id: I5406f9bc4a085aa164c4565a9667ad2925105190
Signed-off-by: Jacek Centkowski <geminica.programs@gmail.com>
org.eclipse.jgit.lfs.server/src/org/eclipse/jgit/lfs/server/fs/FileLfsServlet.java

index 39aaa91d045b903b30424b6d12e1758d5d26b91a..2ecba6d0292b0a31f0ea9e4461f1efc99c606972 100644 (file)
@@ -128,13 +128,14 @@ public class FileLfsServlet extends HttpServlet {
        private AnyLongObjectId getObjectToTransfer(HttpServletRequest req,
                        HttpServletResponse rsp) throws IOException {
                String info = req.getPathInfo();
-               if (info.length() != 1 + Constants.LONG_OBJECT_ID_STRING_LENGTH) {
+               int length = 1 + Constants.LONG_OBJECT_ID_STRING_LENGTH;
+               if (info.length() != length) {
                        sendError(rsp, HttpStatus.SC_UNPROCESSABLE_ENTITY, MessageFormat
                                        .format(LfsServerText.get().invalidPathInfo, info));
                        return null;
                }
                try {
-                       return LongObjectId.fromString(info.substring(1, 65));
+                       return LongObjectId.fromString(info.substring(1, length));
                } catch (InvalidLongObjectIdException e) {
                        sendError(rsp, HttpStatus.SC_UNPROCESSABLE_ENTITY, e.getMessage());
                        return null;