private ComponentDto getComponent(DbSession session, @Nullable String componentKey) {
if (componentKey == null) {
return null;
- } else {
- ComponentDto component = componentFinder.getByKey(session, componentKey);
- return component;
}
+ return componentFinder.getByKey(session, componentKey);
}
private static Object badRequestIfNullResult(@Nullable Object component, String objectType, String objectKey) {
*/
package org.sonar.db.permission;
-import com.google.common.annotations.VisibleForTesting;
-
public class CountByProjectAndPermissionDto {
private long componentId;
private String permission;
// used by MyBatis
}
- @VisibleForTesting
- public CountByProjectAndPermissionDto(long componentId, String permission, int count) {
- this.componentId = componentId;
- this.permission = permission;
- this.count = count;
- }
-
public long getComponentId() {
return componentId;
}
*/
public List<String> selectLogins(DbSession dbSession, PermissionQuery query) {
return select(dbSession, query, null).stream()
- .map(p -> p.getUserLogin())
+ .map(ExtendedUserPermissionDto::getUserLogin)
.distinct()
.collect(Collectors.toList());
}
.setComponentUuid(projectUuid)
.build();
return select(dbSession, query, asList(userLogin)).stream()
- .map(p -> p.getPermission())
+ .map(ExtendedUserPermissionDto::getPermission)
.collect(Collectors.toSet());
}
*
* @param query non-null query including optional filters.
* @param userLogins if null, then filter on all active users. If not null, then filter on logins, including disabled users.
- * Must not be empty. If not null then maximum size is 1'000.
+ * Must not be empty. If not null then maximum size is {@link org.sonar.db.DatabaseUtils#PARTITION_SIZE_FOR_ORACLE}.
*/
List<ExtendedUserPermissionDto> selectByQuery(@Param("query") PermissionQuery query, @Nullable @Param("userLogins") Collection<String> userLogins, RowBounds rowBounds);
mapper(session).deleteGroupRolesByResourceId(projectId);
}
- private int countResourceGroupRoles(DbSession session, Long resourceId) {
+ private static int countResourceGroupRoles(DbSession session, Long resourceId) {
return mapper(session).countResourceGroupRoles(resourceId);
}
- private int countResourceUserRoles(DbSession session, Long resourceId) {
+ private static int countResourceUserRoles(DbSession session, Long resourceId) {
return mapper(session).countResourceUserRoles(resourceId);
}
public void should_update_permission_template() {
db.prepareDbUnit(getClass(), "updatePermissionTemplate.xml");
- PermissionTemplateDto dto = new PermissionTemplateDto();
- dto.setId(1L);
- dto.setName("new_name");
- dto.setDescription("new_description");
- dto.setKeyPattern("new_regexp");
+ PermissionTemplateDto dto = new PermissionTemplateDto()
+ .setId(1L)
+ .setName("new_name")
+ .setDescription("new_description")
+ .setKeyPattern("new_regexp");
underTest.update(dbSession, dto);
db.assertDbUnitTable(getClass(), "updatePermissionTemplate-result.xml", "permission_templates", "id", "name", "kee", "description");