Add test to ensure that symlinked apps_paths are not resolved

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

diff --git a/tests/lib/App/AppManagerTest.php b/tests/lib/App/AppManagerTest.php
index 1a5d6c648a1fa25d679408e1bffc18e47159596b..5b6fedb1cc228b427a2773c1096404c44752f902 100644 (file)
--- a/tests/lib/App/AppManagerTest.php
+++ b/tests/lib/App/AppManagerTest.php
@@ -338,6 +338,35 @@ class AppManagerTest extends TestCase {
                $this->assertEquals(\OC::$SERVERROOT . '/apps/files', $this->manager->getAppPath('files'));
        }
 
+       public function testGetAppPathSymlink() {
+               $fakeAppDirname = sha1(uniqid('test', true));
+               $fakeAppPath = sys_get_temp_dir() . '/' . $fakeAppDirname;
+               $fakeAppLink = \OC::$SERVERROOT . '/' . $fakeAppDirname;
+
+               mkdir($fakeAppPath);
+               if (symlink($fakeAppPath, $fakeAppLink) === false) {
+                       $this->markTestSkipped('Failed to create symlink');
+               }
+
+               // Use the symlink as the app path
+               \OC::$APPSROOTS[] = [
+                       'path' => $fakeAppLink,
+                       'url' => \OC::$WEBROOT . '/' . $fakeAppDirname,
+                       'writable' => false,
+               ];
+
+               $fakeTestAppPath = $fakeAppPath . '/' . 'test-test-app';
+               mkdir($fakeTestAppPath);
+
+               $generatedAppPath = $this->manager->getAppPath('test-test-app');
+
+               rmdir($fakeTestAppPath);
+               unlink($fakeAppLink);
+               rmdir($fakeAppPath);
+
+               $this->assertEquals($fakeAppLink . '/test-test-app', $generatedAppPath);
+       }
+
        public function testGetAppPathFail() {
                $this->expectException(AppPathNotFoundException::class);
                $this->manager->getAppPath('testnotexisting');