]> source.dussan.org Git - nextcloud-server.git/commitdiff
Type hints already make sure it is an array 1937/head
authorJoas Schilling <coding@schilljs.com>
Fri, 28 Oct 2016 07:23:43 +0000 (09:23 +0200)
committerJoas Schilling <coding@schilljs.com>
Mon, 31 Oct 2016 09:37:40 +0000 (10:37 +0100)
Signed-off-by: Joas Schilling <coding@schilljs.com>
lib/private/Notification/Notification.php

index 39fc6ab9465237c3b5c4392d37c3027c2ca1bae5..ffcb36af6e5b817c6442fa13cc1e81794f2fa589 100644 (file)
@@ -239,12 +239,10 @@ class Notification implements INotification {
                if (!is_string($subject) || $subject === '' || isset($subject[64])) {
                        throw new \InvalidArgumentException('The given subject is invalid');
                }
-               $this->subject = $subject;
 
-               if (!is_array($parameters)) {
-                       throw new \InvalidArgumentException('The given subject parameters are invalid');
-               }
+               $this->subject = $subject;
                $this->subjectParameters = $parameters;
+
                return $this;
        }
 
@@ -297,11 +295,8 @@ class Notification implements INotification {
                if (!is_string($subject) || $subject === '') {
                        throw new \InvalidArgumentException('The given parsed subject is invalid');
                }
-               $this->subjectRich = $subject;
 
-               if (!is_array($parameters)) {
-                       throw new \InvalidArgumentException('The given subject parameters are invalid');
-               }
+               $this->subjectRich = $subject;
                $this->subjectRichParameters = $parameters;
 
                return $this;
@@ -334,12 +329,10 @@ class Notification implements INotification {
                if (!is_string($message) || $message === '' || isset($message[64])) {
                        throw new \InvalidArgumentException('The given message is invalid');
                }
-               $this->message = $message;
 
-               if (!is_array($parameters)) {
-                       throw new \InvalidArgumentException('The given message parameters are invalid');
-               }
+               $this->message = $message;
                $this->messageParameters = $parameters;
+
                return $this;
        }
 
@@ -392,11 +385,8 @@ class Notification implements INotification {
                if (!is_string($message) || $message === '') {
                        throw new \InvalidArgumentException('The given parsed message is invalid');
                }
-               $this->messageRich = $message;
 
-               if (!is_array($parameters)) {
-                       throw new \InvalidArgumentException('The given message parameters are invalid');
-               }
+               $this->messageRich = $message;
                $this->messageRichParameters = $parameters;
 
                return $this;