Use formal type hints instead of informal PHPDoc

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

diff --git a/lib/private/BackgroundJob/Job.php b/lib/private/BackgroundJob/Job.php
index 30326b6a4f447fd0ea613519cf93659c3bd2a5da..a464ea2ba1ff88584ccd39bf71db1ae748401376 100644 (file)
--- a/lib/private/BackgroundJob/Job.php
+++ b/lib/private/BackgroundJob/Job.php
@@ -32,26 +32,16 @@ use OCP\BackgroundJob\IJobList;
 use OCP\ILogger;
 
 abstract class Job implements IJob {
-       /**
-        * @var int $id
-        */
+       /** @var int */
        protected $id;
 
-       /**
-        * @var int $lastRun
-        */
+       /** @var int */
        protected $lastRun;
 
-       /**
-        * @var mixed $argument
-        */
+       /** @var mixed */
        protected $argument;
 
-       /**
-        * @param IJobList $jobList
-        * @param ILogger|null $logger
-        */
-       public function execute($jobList, ILogger $logger = null) {
+       public function execute(IJobList $jobList, ILogger $logger = null) {
                $jobList->setLastRun($this);
                if ($logger === null) {
                        $logger = \OC::$server->getLogger();
@@ -77,11 +67,11 @@ abstract class Job implements IJob {
 
        abstract protected function run($argument);
 
-       public function setId($id) {
+       public function setId(int $id) {
                $this->id = $id;
        }
 
-       public function setLastRun($lastRun) {
+       public function setLastRun(int $lastRun) {
                $this->lastRun = $lastRun;
        }
 

diff --git a/lib/public/BackgroundJob/IJob.php b/lib/public/BackgroundJob/IJob.php
index e9c8ddedeea5ea0c204294f489555894fdfe75f1..a61f70a3cf4792be0b7f26640b796a3124c02d5b 100644 (file)
--- a/lib/public/BackgroundJob/IJob.php
+++ b/lib/public/BackgroundJob/IJob.php
@@ -42,19 +42,17 @@ interface IJob {
         * @param ILogger|null $logger
         * @since 7.0.0
         */
-       public function execute($jobList, ILogger $logger = null);
+       public function execute(IJobList $jobList, ILogger $logger = null);
 
        /**
-        * @param int $id
         * @since 7.0.0
         */
-       public function setId($id);
+       public function setId(int $id);
 
        /**
-        * @param int $lastRun
         * @since 7.0.0
         */
-       public function setLastRun($lastRun);
+       public function setLastRun(int $lastRun);
 
        /**
         * @param mixed $argument