Warn about adding NotNull columns with nullable default

Signed-off-by: Joas Schilling <coding@schilljs.com>

diff --git a/lib/private/DB/MigrationService.php b/lib/private/DB/MigrationService.php
index 42204dd155aa1cf0c4b9478d01ff520798e7397f..cd0280162d3826bb495c40df83e24ed16d7dba43 100644 (file)
--- a/lib/private/DB/MigrationService.php
+++ b/lib/private/DB/MigrationService.php
@@ -513,6 +513,11 @@ class MigrationService {
                                if ((!$sourceTable instanceof Table || !$sourceTable->hasColumn($thing->getName())) && \strlen($thing->getName()) > 30) {
                                        throw new \InvalidArgumentException('Column name "'  . $table->getName() . '"."' . $thing->getName() . '" is too long.');
                                }
+
+                               if ($thing->getNotnull() && $thing->getDefault() === ''
+                                       && $sourceTable instanceof Table && !$sourceTable->hasColumn($thing->getName())) {
+                                       throw new \InvalidArgumentException('Column name "'  . $table->getName() . '"."' . $thing->getName() . '" is NotNull, but has empty string or null as default.');
+                               }
                        }
 
                        foreach ($table->getIndexes() as $thing) {