]> source.dussan.org Git - nextcloud-server.git/commitdiff
SharedMountTest.php:367 is unreliable 23498/head
authorMorris Jobke <hey@morrisjobke.de>
Thu, 15 Oct 2020 22:36:23 +0000 (00:36 +0200)
committerbackportbot[bot] <backportbot[bot]@users.noreply.github.com>
Fri, 16 Oct 2020 06:41:23 +0000 (06:41 +0000)
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
apps/files_sharing/tests/SharedMountTest.php

index c60039e321a6675ba654d764bef63aeb22ef270c..b5cb02ed3c250c576fec7fba6afebc50ed62fe4a 100644 (file)
@@ -336,6 +336,7 @@ class SharedMountTest extends TestCase {
         * @dataProvider dataPermissionMovedGroupShare
         */
        public function testPermissionMovedGroupShare($type, $beforePerm, $afterPerm) {
+               $this->markTestSkipped('Unreliable test');
                if ($type === 'file') {
                        $path = $this->filename;
                } elseif ($type === 'folder') {
@@ -364,7 +365,7 @@ class SharedMountTest extends TestCase {
 
                // Login as user 2 and verify the item exists
                self::loginHelper(self::TEST_FILES_SHARING_API_USER2);
-               $this->assertTrue(\OC\Files\Filesystem::file_exists($path));
+               $this->assertTrue(\OC\Files\Filesystem::file_exists($path)); // TODO: unreliable - this is sometimes false
                $result = $this->shareManager->getShareById($share->getFullId(), self::TEST_FILES_SHARING_API_USER2);
                $this->assertEquals($beforePerm, $result->getPermissions());