]> source.dussan.org Git - nextcloud-server.git/commitdiff
SCSSCacher - Lock should not be removed 23510/head
authorMorris Jobke <hey@morrisjobke.de>
Thu, 15 Oct 2020 21:48:26 +0000 (23:48 +0200)
committerbackportbot[bot] <backportbot[bot]@users.noreply.github.com>
Fri, 16 Oct 2020 11:27:36 +0000 (11:27 +0000)
This is within the failed lock acquiring branch. So the lock is free by another process and should not be removed because the cached file (that was created by the process having the lock) appeared on the filesystem.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
lib/private/Template/SCSSCacher.php

index cf156942592eaaa80466ed3bdbebcd080f0cfe2c..597d4323d3c2fdacbe3fd7e36d26cd56e8e23f08 100644 (file)
@@ -169,7 +169,6 @@ class SCSSCacher {
                                $this->logger->debug('SCSSCacher::process check in while loop follows', ['app' => 'scss_cacher']);
                                if (!$this->variablesChanged() && $this->isCached($fileNameCSS, $app)) {
                                        // Inject icons vars css if any
-                                       $this->lockingCache->remove($lockKey);
                                        $this->logger->debug("SCSSCacher::process cached file for app '$app' and file '$fileNameCSS' is now available after $retry s. Moving on...", ['app' => 'scss_cacher']);
                                        return $this->injectCssVariablesIfAny();
                                }