Remove tests that just prove mocked calls and don't actually validate anything useful

Signed-off-by: Julius Härtl <jus@bitgrid.net>

diff --git a/tests/lib/Security/CredentialsManagerTest.php b/tests/lib/Security/CredentialsManagerTest.php
index 3335e18a8b1f5002e7cbbd129aed3dfce9d85c47..f81db3306405abc27e009c5fdd858d2e3d0aeedd 100644 (file)
--- a/tests/lib/Security/CredentialsManagerTest.php
+++ b/tests/lib/Security/CredentialsManagerTest.php
@@ -24,92 +24,11 @@ declare(strict_types=1);
 
 namespace Test\Security;
 
-use OC\Security\CredentialsManager;
-use OCP\DB\IResult;
-use OCP\DB\QueryBuilder\IExpressionBuilder;
-use OCP\DB\QueryBuilder\IQueryBuilder;
-use OCP\IDBConnection;
-use OCP\Security\ICrypto;
-
 /**
  * @group DB
  */
 class CredentialsManagerTest extends \Test\TestCase {
 
-       /** @var ICrypto */
-       protected $crypto;
-
-       /** @var IDBConnection */
-       protected $dbConnection;
-
-       /** @var CredentialsManager */
-       protected $manager;
-
-       protected function setUp(): void {
-               parent::setUp();
-               $this->crypto = $this->createMock(ICrypto::class);
-               $this->dbConnection = $this->getMockBuilder(IDBConnection::class)
-                       ->disableOriginalConstructor()
-                       ->getMock();
-               $this->manager = new CredentialsManager($this->crypto, $this->dbConnection);
-       }
-
-       private function getQueryResult($row) {
-               $result = $this->createMock(IResult::class);
-
-               $result->expects($this->any())
-                       ->method('fetch')
-                       ->willReturn($row);
-
-               return $result;
-       }
-
-       public function testStore() {
-               $userId = 'abc';
-               $identifier = 'foo';
-               $credentials = 'bar';
-
-               $this->crypto->expects($this->once())
-                       ->method('encrypt')
-                       ->with(json_encode($credentials))
-                       ->willReturn('baz');
-
-               $this->dbConnection->expects($this->once())
-                       ->method('setValues')
-                       ->with(CredentialsManager::DB_TABLE,
-                               ['user' => $userId, 'identifier' => $identifier],
-                               ['credentials' => 'baz']
-                       );
-
-               $this->manager->store($userId, $identifier, $credentials);
-       }
-
-       public function testRetrieve() {
-               $userId = 'abc';
-               $identifier = 'foo';
-
-               $this->crypto->expects($this->once())
-                       ->method('decrypt')
-                       ->with('baz')
-                       ->willReturn(json_encode('bar'));
-
-               $eb = $this->createMock(IExpressionBuilder::class);
-               $qb = $this->createMock(IQueryBuilder::class);
-               $qb->method('select')->willReturnSelf();
-               $qb->method('from')->willReturnSelf();
-               $qb->method('where')->willReturnSelf();
-               $qb->method('expr')->willReturn($eb);
-               $qb->expects($this->once())
-                       ->method('execute')
-                       ->willReturn($this->getQueryResult(['credentials' => 'baz']));
-
-               $this->dbConnection->expects($this->once())
-                       ->method('getQueryBuilder')
-                       ->willReturn($qb);
-
-               $this->manager->retrieve($userId, $identifier);
-       }
-
        /**
         * @dataProvider credentialsProvider
         */

diff --git a/tests/lib/TestCase.php b/tests/lib/TestCase.php
index 11bfd750387b274a4bf99f8175fcc8eab3a7504a..b5dcd76faf90edc97ae4cd4def0e0e0735f8f057 100644 (file)
--- a/tests/lib/TestCase.php
+++ b/tests/lib/TestCase.php
@@ -33,7 +33,6 @@ use OCP\Defaults;
 use OCP\IDBConnection;
 use OCP\IL10N;
 use OCP\Security\ISecureRandom;
-use PHPUnit\Util\Test;
 
 abstract class TestCase extends \PHPUnit\Framework\TestCase {
        /** @var \OC\Command\QueueBus */