Check background job type

It is assumed that a job class loaded from the jobs table is an IJob,
but due to programming error the job might be of another type. Then the
setters will most likely fail.

This patch adds an interface type check so only correct jobs are used,
anything else is ignored.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

diff --git a/lib/private/BackgroundJob/JobList.php b/lib/private/BackgroundJob/JobList.php
index fe65a1879bcc49b8b2662d3a39d1f104f1356bb6..7ab86df84556a5e1c96d9759fa8b950819c5b735 100644 (file)
--- a/lib/private/BackgroundJob/JobList.php
+++ b/lib/private/BackgroundJob/JobList.php
@@ -311,6 +311,10 @@ class JobList implements IJobList {
                                }
                        }
 
+                       if (!($job instanceof IJob)) {
+                               // This most likely means an invalid job was enqueued. We can ignore it.
+                               return null;
+                       }
                        $job->setId((int) $row['id']);
                        $job->setLastRun((int) $row['last_run']);
                        $job->setArgument(json_decode($row['argument'], true));