]> source.dussan.org Git - nextcloud-server.git/commitdiff
techdebt(Middleware): Add more specific array types so its clickable in IDEs 41931/head
authorJoas Schilling <coding@schilljs.com>
Thu, 30 Nov 2023 11:27:08 +0000 (12:27 +0100)
committerJoas Schilling <coding@schilljs.com>
Thu, 30 Nov 2023 11:27:08 +0000 (12:27 +0100)
Signed-off-by: Joas Schilling <coding@schilljs.com>
lib/private/AppFramework/Middleware/MiddlewareDispatcher.php

index 35eb0098eedc0a8d374d8e42c28e85c4770109de..e129f70aef6d35c208dc7bdba41053af022ea2d3 100644 (file)
@@ -40,15 +40,15 @@ use OCP\AppFramework\Middleware;
  */
 class MiddlewareDispatcher {
        /**
-        * @var array array containing all the middlewares
+        * @var Middleware[] array containing all the middlewares
         */
-       private $middlewares;
+       private array $middlewares;
 
        /**
         * @var int counter which tells us what middleware was executed once an
         *                  exception occurs
         */
-       private $middlewareCounter;
+       private int $middlewareCounter;
 
 
        /**
@@ -64,14 +64,14 @@ class MiddlewareDispatcher {
         * Adds a new middleware
         * @param Middleware $middleWare the middleware which will be added
         */
-       public function registerMiddleware(Middleware $middleWare) {
+       public function registerMiddleware(Middleware $middleWare): void {
                $this->middlewares[] = $middleWare;
        }
 
 
        /**
         * returns an array with all middleware elements
-        * @return array the middlewares
+        * @return Middleware[] the middlewares
         */
        public function getMiddlewares(): array {
                return $this->middlewares;
@@ -86,7 +86,7 @@ class MiddlewareDispatcher {
         * @param string $methodName the name of the method that will be called on
         *                           the controller
         */
-       public function beforeController(Controller $controller, string $methodName) {
+       public function beforeController(Controller $controller, string $methodName): void {
                // we need to count so that we know which middlewares we have to ask in
                // case there is an exception
                $middlewareCount = \count($this->middlewares);