fix tests after improve PluginDescriptorFinder

diff --git a/pf4j/src/main/java/ro/fortsoft/pf4j/ManifestPluginDescriptorFinder.java b/pf4j/src/main/java/ro/fortsoft/pf4j/ManifestPluginDescriptorFinder.java
index eed54bde01b613b1f5b41ff338f0f958b529d006..55b00599cd5e6e9fd2c4a3b2753918a89454d3de 100644 (file)
--- a/pf4j/src/main/java/ro/fortsoft/pf4j/ManifestPluginDescriptorFinder.java
+++ b/pf4j/src/main/java/ro/fortsoft/pf4j/ManifestPluginDescriptorFinder.java
@@ -100,7 +100,9 @@ public class ManifestPluginDescriptorFinder implements PluginDescriptorFinder {
         pluginDescriptor.setPluginClass(clazz);
 
         String version = attributes.getValue("Plugin-Version");
-        pluginDescriptor.setPluginVersion(Version.valueOf(version));
+        if (StringUtils.isNotEmpty(version)) {
+            pluginDescriptor.setPluginVersion(Version.valueOf(version));
+        }
 
         String provider = attributes.getValue("Plugin-Provider");
         pluginDescriptor.setProvider(provider);
@@ -122,6 +124,9 @@ public class ManifestPluginDescriptorFinder implements PluginDescriptorFinder {
         if (StringUtils.isEmpty(pluginDescriptor.getPluginClass())) {
             throw new PluginException("Plugin-Class cannot be empty");
         }
+        if (pluginDescriptor.getVersion() == null) {
+            throw new PluginException("Plugin-Version cannot be empty");
+        }
     }
 
 }

diff --git a/pf4j/src/main/java/ro/fortsoft/pf4j/PropertiesPluginDescriptorFinder.java b/pf4j/src/main/java/ro/fortsoft/pf4j/PropertiesPluginDescriptorFinder.java
index a6d35c9fd9b0a183449710a1340cf4d7d5e4ee0a..a0703e8cbda336bb7313a1119c0e9e6cd1ebd698 100644 (file)
--- a/pf4j/src/main/java/ro/fortsoft/pf4j/PropertiesPluginDescriptorFinder.java
+++ b/pf4j/src/main/java/ro/fortsoft/pf4j/PropertiesPluginDescriptorFinder.java
@@ -96,7 +96,9 @@ public class PropertiesPluginDescriptorFinder implements PluginDescriptorFinder
         pluginDescriptor.setPluginClass(clazz);
 
         String version = properties.getProperty("plugin.version");
-        pluginDescriptor.setPluginVersion(Version.valueOf(version));
+        if (StringUtils.isNotEmpty(version)) {
+            pluginDescriptor.setPluginVersion(Version.valueOf(version));
+        }
 
         String provider = properties.getProperty("plugin.provider");
         pluginDescriptor.setProvider(provider);
@@ -110,11 +112,13 @@ public class PropertiesPluginDescriptorFinder implements PluginDescriptorFinder
     protected void validatePluginDescriptor(PluginDescriptor pluginDescriptor) throws PluginException {
         if (StringUtils.isEmpty(pluginDescriptor.getPluginId())) {
             throw new PluginException("plugin.id cannot be empty");
-
         }
         if (StringUtils.isEmpty(pluginDescriptor.getPluginClass())) {
             throw new PluginException("plugin.class cannot be empty");
         }
+        if (pluginDescriptor.getVersion() == null) {
+            throw new PluginException("plugin.version cannot be empty");
+        }
     }
 
 }