Whitelist the "target" link attribute in the XSS filter

diff --git a/releases.moxie b/releases.moxie
index 2bca1a7442b653fc1ac3e9382d27f85f6a9f5f56..d98c2d411af6b25144efe2b79f92cc73a32102ce 100644 (file)
--- a/releases.moxie
+++ b/releases.moxie
@@ -18,6 +18,7 @@ r27: {
     - Fix exception when viewing a ticket with a patchset where the integration branch does not exist (issue-521, ticket-212)
     - Fix exception when deleting a repository using the FileTicketService (issue-522, ticket-213)
     - Do not inject team repository permissions as explicit user permissoins when editing a user (issue-462, ticket-214)
+    - Whitelist the target link attribute in the XSS filter (ticket-216)
     changes:
     - Replaced Dagger with Guice (ticket-80)
     - Use release name as root directory in Gitblit GO artifacts (ticket-109)
@@ -41,6 +42,7 @@ r27: {
     - Florian Zschocke
     - Paul Martin
     - razzard
+    - Alexander Zabluda
 }
 
 #

diff --git a/src/main/java/com/gitblit/utils/JSoupXssFilter.java b/src/main/java/com/gitblit/utils/JSoupXssFilter.java
index b5ac59f634418a3c99bcd1740eb094d44870e96f..aec22411a180410e5b67020a11eae31c1b10ee81 100644 (file)
--- a/src/main/java/com/gitblit/utils/JSoupXssFilter.java
+++ b/src/main/java/com/gitblit/utils/JSoupXssFilter.java
@@ -73,7 +73,7 @@ public class JSoupXssFilter implements XssFilter {
                 "sub", "sup", "table", "tbody", "td", "tfoot", "th", "thead", "tr", "tt", "u",
                 "ul", "var")
 
-        .addAttributes("a", "class", "href", "style", "title")
+        .addAttributes("a", "class", "href", "style", "target", "title")
         .addAttributes("blockquote", "cite")
         .addAttributes("col", "span", "width")
         .addAttributes("colgroup", "span", "width")