From: Artur Signell <artur@vaadin.com>
Date: Thu, 22 Dec 2011 07:58:21 +0000 (+0200)
Subject: #8173 Deprecated separate read through and write through modes
X-Git-Tag: 7.0.0.alpha1~32
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=088d47b54552bb4a3b4a22a3edf06262a415e9e3;p=vaadin-framework.git

#8173 Deprecated separate read through and write through modes
---

diff --git a/src/com/vaadin/data/Buffered.java b/src/com/vaadin/data/Buffered.java
index 6498ca519d..22a4b6f9f7 100644
--- a/src/com/vaadin/data/Buffered.java
+++ b/src/com/vaadin/data/Buffered.java
@@ -77,7 +77,11 @@ public interface Buffered extends Serializable {
      * 
      * @return <code>true</code> if the object is in write-through mode,
      *         <code>false</code> if it's not.
+     * @deprecated Use {@link #setBuffered(boolean)} instead. Note that
+     *             setReadThrough(true), setWriteThrough(true) equals
+     *             setBuffered(false)
      */
+    @Deprecated
     public boolean isWriteThrough();
 
     /**
@@ -95,7 +99,11 @@ public interface Buffered extends Serializable {
      *             If the implicit commit operation fails because of a
      *             validation error.
      * 
+     * @deprecated Use {@link #setBuffered(boolean)} instead. Note that
+     *             setReadThrough(true), setWriteThrough(true) equals
+     *             setBuffered(false)
      */
+    @Deprecated
     public void setWriteThrough(boolean writeThrough) throws SourceException,
             InvalidValueException;
 
@@ -112,7 +120,11 @@ public interface Buffered extends Serializable {
      * 
      * @return <code>true</code> if the object is in read-through mode,
      *         <code>false</code> if it's not.
+     * @deprecated Use {@link #isBuffered(boolean)} instead. Note that
+     *             setReadThrough(true), setWriteThrough(true) equals
+     *             setBuffered(false)
      */
+    @Deprecated
     public boolean isReadThrough();
 
     /**
@@ -127,7 +139,11 @@ public interface Buffered extends Serializable {
      * @throws SourceException
      *             If the operation fails because of an exception is thrown by
      *             the data source. The cause is included in the exception.
+     * @deprecated Use {@link #setBuffered(boolean)} instead. Note that
+     *             setReadThrough(true), setWriteThrough(true) equals
+     *             setBuffered(false)
      */
+    @Deprecated
     public void setReadThrough(boolean readThrough) throws SourceException;
 
     /**
diff --git a/src/com/vaadin/ui/AbstractField.java b/src/com/vaadin/ui/AbstractField.java
index d67c553426..4f944ce17b 100644
--- a/src/com/vaadin/ui/AbstractField.java
+++ b/src/com/vaadin/ui/AbstractField.java
@@ -409,8 +409,11 @@ public abstract class AbstractField<T> extends AbstractComponent implements
      * @throws InvalidValueException
      *             If the implicit commit operation fails because of a
      *             validation error.
-     * 
+     * @deprecated Use {@link #setBuffered(boolean)} instead. Note that
+     *             setReadThrough(true), setWriteThrough(true) equals
+     *             setBuffered(false)
      */
+    @Deprecated
     public void setWriteThrough(boolean writeThrough)
             throws Buffered.SourceException, InvalidValueException {
         if (writeThroughMode == writeThrough) {
@@ -445,7 +448,11 @@ public abstract class AbstractField<T> extends AbstractComponent implements
      * @throws SourceException
      *             If the operation fails because of an exception is thrown by
      *             the data source. The cause is included in the exception.
+     * @deprecated Use {@link #setBuffered(boolean)} instead. Note that
+     *             setReadThrough(true), setWriteThrough(true) equals
+     *             setBuffered(false)
      */
+    @Deprecated
     public void setReadThrough(boolean readThrough)
             throws Buffered.SourceException {
         if (readThroughMode == readThrough) {
diff --git a/src/com/vaadin/ui/Form.java b/src/com/vaadin/ui/Form.java
index 2feddb647b..d078c2103a 100644
--- a/src/com/vaadin/ui/Form.java
+++ b/src/com/vaadin/ui/Form.java
@@ -422,6 +422,7 @@ public class Form extends AbstractField<Object> implements Item.Editor,
      * we use the default one from the interface.
      */
     @Override
+    @Deprecated
     public boolean isReadThrough() {
         return readThrough;
     }
@@ -431,6 +432,7 @@ public class Form extends AbstractField<Object> implements Item.Editor,
      * we use the default one from the interface.
      */
     @Override
+    @Deprecated
     public boolean isWriteThrough() {
         return writeThrough;
     }
diff --git a/tests/server-side/com/vaadin/tests/server/components/TestTextFieldValueChange.java b/tests/server-side/com/vaadin/tests/server/components/TestTextFieldValueChange.java
index ebe2b14fa1..d5cb02b477 100644
--- a/tests/server-side/com/vaadin/tests/server/components/TestTextFieldValueChange.java
+++ b/tests/server-side/com/vaadin/tests/server/components/TestTextFieldValueChange.java
@@ -55,8 +55,7 @@ public class TestTextFieldValueChange extends
         getField().setPropertyDataSource(property);
 
         // defaults, buffering off
-        getField().setWriteThrough(true);
-        getField().setReadThrough(true);
+        getField().setBuffered(false);
 
         // Expectations and start test
         getListener().valueChange(EasyMock.isA(ValueChangeEvent.class));
@@ -143,8 +142,7 @@ public class TestTextFieldValueChange extends
                 initialValue);
 
         // set buffering
-        getField().setWriteThrough(false);
-        getField().setReadThrough(false);
+        getField().setBuffered(true);
 
         // Value change should only happen once, when setting the property,
         // further changes via property should not cause value change listener
diff --git a/tests/testbench/com/vaadin/tests/tickets/Ticket2151.java b/tests/testbench/com/vaadin/tests/tickets/Ticket2151.java
index 808e7d3b1c..c2fbe1b4f7 100644
--- a/tests/testbench/com/vaadin/tests/tickets/Ticket2151.java
+++ b/tests/testbench/com/vaadin/tests/tickets/Ticket2151.java
@@ -90,8 +90,7 @@ public class Ticket2151 extends Application.LegacyApplication {
             b = class1.newInstance();
             b.setCaption("Button of type " + class1.getSimpleName());
             try {
-                b.setWriteThrough(true);
-                b.setReadThrough(true);
+                b.setBuffered(false);
                 ObjectProperty<String> prop = new ObjectProperty<String>(
                         "ABC 123");
                 /*
diff --git a/tests/testbench/com/vaadin/tests/tickets/Ticket736.java b/tests/testbench/com/vaadin/tests/tickets/Ticket736.java
index 48bd29fcc5..091e0c97af 100644
--- a/tests/testbench/com/vaadin/tests/tickets/Ticket736.java
+++ b/tests/testbench/com/vaadin/tests/tickets/Ticket736.java
@@ -39,8 +39,7 @@ public class Ticket736 extends Application.LegacyApplication {
         mainWin.addComponent(f);
 
         // Select to use buffered mode for editing to enable commit and discard
-        f.setWriteThrough(false);
-        f.setReadThrough(false);
+        f.setBuffered(true);
         Button commit = new Button("Commit", new ClickListener() {
 
             public void buttonClick(ClickEvent event) {