From: 7PH <benjamin.raymond@sonarsource.com>
Date: Mon, 24 Apr 2023 11:17:23 +0000 (+0200)
Subject: SONAR-19069 Add dismissable alert on first new facets encounter
X-Git-Tag: 10.1.0.73491~400
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=0aca567691b9cfb51f272b2a548e99d3077cfef1;p=sonarqube.git

SONAR-19069 Add dismissable alert on first new facets encounter
---

diff --git a/server/sonar-web/src/main/js/apps/issues/sidebar/Sidebar.tsx b/server/sonar-web/src/main/js/apps/issues/sidebar/Sidebar.tsx
index c677090a724..837553f40a7 100644
--- a/server/sonar-web/src/main/js/apps/issues/sidebar/Sidebar.tsx
+++ b/server/sonar-web/src/main/js/apps/issues/sidebar/Sidebar.tsx
@@ -19,7 +19,10 @@
  */
 import * as React from 'react';
 import withAppStateContext from '../../../app/components/app-state/withAppStateContext';
+import DocLink from '../../../components/common/DocLink';
+import DismissableAlert from '../../../components/ui/DismissableAlert';
 import { isBranch, isPullRequest } from '../../../helpers/branch-like';
+import { translate } from '../../../helpers/l10n';
 import { AppState } from '../../../types/appstate';
 import { BranchLike } from '../../../types/branch-like';
 import {
@@ -169,6 +172,11 @@ export class Sidebar extends React.PureComponent<Props> {
             newCodeSelected={query.inNewCodePeriod}
           />
         )}
+        <DismissableAlert alertKey="issues-characteristic-facets" variant="info" display="inline">
+          <strong>{translate('issues.characteristic.facet-highlight.title')}</strong>
+          <br />
+          <DocLink to="/what-sonarqube-can-do">{translate('learn_more')}</DocLink>
+        </DismissableAlert>
         <CharacteristicFacet
           fetching={loadingFacets.characteristics === true}
           onChange={this.props.onFilterChange}
diff --git a/server/sonar-web/src/main/js/apps/issues/sidebar/__tests__/Sidebar-it.tsx b/server/sonar-web/src/main/js/apps/issues/sidebar/__tests__/Sidebar-it.tsx
index b1d4d1ca4dd..83968ea3262 100644
--- a/server/sonar-web/src/main/js/apps/issues/sidebar/__tests__/Sidebar-it.tsx
+++ b/server/sonar-web/src/main/js/apps/issues/sidebar/__tests__/Sidebar-it.tsx
@@ -28,9 +28,15 @@ import { IssueSeverity } from '../../../../types/issues';
 import { GlobalSettingKeys } from '../../../../types/settings';
 import { Sidebar } from '../Sidebar';
 
+const getFacetNames = () =>
+  screen
+    .getAllByRole('button')
+    .map((button) => button.textContent)
+    .filter((name) => !!name);
+
 it('should render correct facets for Application', () => {
   renderSidebar({ component: mockComponent({ qualifier: ComponentQualifier.Application }) });
-  expect(screen.getAllByRole('button').map((button) => button.textContent)).toStrictEqual([
+  expect(getFacetNames()).toStrictEqual([
     'issues.facet.characteristics.PRODUCTION',
     'issues.facet.characteristics.DEVELOPMENT',
     'issues.facet.severities',
@@ -52,7 +58,7 @@ it('should render correct facets for Application', () => {
 
 it('should render correct facets for Portfolio', () => {
   renderSidebar({ component: mockComponent({ qualifier: ComponentQualifier.Portfolio }) });
-  expect(screen.getAllByRole('button').map((button) => button.textContent)).toStrictEqual([
+  expect(getFacetNames()).toStrictEqual([
     'issues.facet.characteristics.PRODUCTION',
     'issues.facet.characteristics.DEVELOPMENT',
     'issues.facet.severities',
@@ -74,7 +80,7 @@ it('should render correct facets for Portfolio', () => {
 
 it('should render correct facets for SubPortfolio', () => {
   renderSidebar({ component: mockComponent({ qualifier: ComponentQualifier.SubPortfolio }) });
-  expect(screen.getAllByRole('button').map((button) => button.textContent)).toStrictEqual([
+  expect(getFacetNames()).toStrictEqual([
     'issues.facet.characteristics.PRODUCTION',
     'issues.facet.characteristics.DEVELOPMENT',
     'issues.facet.severities',
@@ -101,7 +107,7 @@ it('should render only main visible facets: Characteristics & Severity', () => {
     query: mockQuery({ assigned: true }),
   });
 
-  expect(screen.getAllByRole('button').map((button) => button.textContent)).toStrictEqual([
+  expect(getFacetNames()).toStrictEqual([
     'issues.facet.characteristics.PRODUCTION',
     'issues.facet.characteristics.DEVELOPMENT',
     'issues.facet.severities',
@@ -123,7 +129,7 @@ it('should render secondary facets with filters applied eventhough "Show more fi
     }),
   });
 
-  expect(screen.getAllByRole('button').map((button) => button.textContent)).toStrictEqual([
+  expect(getFacetNames()).toStrictEqual([
     'issues.facet.characteristics.PRODUCTION',
     'issues.facet.characteristics.DEVELOPMENT',
     'issues.facet.severities',
diff --git a/sonar-core/src/main/resources/org/sonar/l10n/core.properties b/sonar-core/src/main/resources/org/sonar/l10n/core.properties
index 6da9c013536..d2e143c4e27 100644
--- a/sonar-core/src/main/resources/org/sonar/l10n/core.properties
+++ b/sonar-core/src/main/resources/org/sonar/l10n/core.properties
@@ -273,6 +273,7 @@ facet_might_have_more_results=There might be more results, try another set of fi
 false_positive=False positive
 go_back_to_homepage=Go back to the homepage
 last_analysis_before=Last analysis before
+learn_more=Learn more
 less_than_1_hour_ago=< 1 hour ago
 local=Local
 logging_out=You're logging out, please wait...
@@ -991,6 +992,7 @@ issues.not_all_issue_show=Not all issues are included
 issues.not_all_issue_show_why=You do not have access to all projects in this portfolio
 issues.show_more_filters=Show more filters
 issues.show_less_filters=Show less filters
+issues.characteristic.facet-highlight.title=New Clean Code characteristics
 
 #------------------------------------------------------------------------------
 #