From: Richard Gibson Date: Thu, 13 Dec 2018 17:54:39 +0000 (-0500) Subject: Manipulation: Restore _evalUrl jQuery.ajax calls to dataType: script X-Git-Tag: 3.4.0~27 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=13de7c9ede1c49c30344b4347985eac341484b1e;p=jquery.git Manipulation: Restore _evalUrl jQuery.ajax calls to dataType: script IE and iOS <10 XHR transport does not succeed on data: URIs Ref gh-4243 Ref gh-4126 Closes gh-4258 --- diff --git a/src/manipulation/_evalUrl.js b/src/manipulation/_evalUrl.js index 1ed033673..e20995a89 100644 --- a/src/manipulation/_evalUrl.js +++ b/src/manipulation/_evalUrl.js @@ -10,15 +10,19 @@ jQuery._evalUrl = function( url ) { // Make this explicit, since user can override this through ajaxSetup (#11264) type: "GET", - dataType: "text", + dataType: "script", cache: true, async: false, global: false, - "throws": true, // Only evaluate the response if it is successful (gh-4126) - success: function( text ) { - jQuery.globalEval( text ); + // dataFilter is not invoked for failure responses, so using it instead + // of the default converter is kludgy but it works. + converters: { + "text script": function() {} + }, + dataFilter: function( response ) { + jQuery.globalEval( response ); } } ); };