From: Simon Brandhof <simon.brandhof@gmail.com>
Date: Thu, 9 Jan 2014 15:27:35 +0000 (+0100)
Subject: Fix quality flaws in class SearchIndex
X-Git-Tag: 4.2~774
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=1524f7aa202253fe7bf8512135e422d5418080b6;p=sonarqube.git

Fix quality flaws in class SearchIndex
---

diff --git a/sonar-server/src/main/java/org/sonar/server/search/SearchIndex.java b/sonar-server/src/main/java/org/sonar/server/search/SearchIndex.java
index bff6f252c90..8970de4a862 100644
--- a/sonar-server/src/main/java/org/sonar/server/search/SearchIndex.java
+++ b/sonar-server/src/main/java/org/sonar/server/search/SearchIndex.java
@@ -45,6 +45,7 @@ import org.elasticsearch.common.xcontent.ToXContent;
 import org.elasticsearch.common.xcontent.XContentFactory;
 import org.elasticsearch.search.SearchHit;
 import org.elasticsearch.search.SearchHits;
+import org.picocontainer.Startable;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.sonar.core.profiling.Profiling;
@@ -57,7 +58,7 @@ import java.util.Arrays;
 import java.util.List;
 import java.util.concurrent.ExecutionException;
 
-public class SearchIndex {
+public class SearchIndex implements Startable {
 
   private static final String BULK_EXECUTE_FAILED = "Execution of bulk operation failed";
   private static final String BULK_INTERRUPTED = "Interrupted during bulk operation";
@@ -82,10 +83,12 @@ public class SearchIndex {
     this.profiling = profiling;
   }
 
+  @Override
   public void start() {
     this.client = searchNode.client();
   }
 
+  @Override
   public void stop() {
     if(client != null) {
       client.close();
@@ -266,8 +269,8 @@ public class SearchIndex {
 
   public void bulkDelete(String index, String type, String[] ids) {
     BulkRequestBuilder builder = new BulkRequestBuilder(client);
-    for (int i=0; i<ids.length; i++) {
-      builder.add(client.prepareDelete(index, type, ids[i]));
+    for (String id : ids) {
+      builder.add(client.prepareDelete(index, type, id));
     }
     StopWatch watch = createWatch();
     try {
diff --git a/sonar-server/src/test/java/org/sonar/server/search/SearchIndexTest.java b/sonar-server/src/test/java/org/sonar/server/search/SearchIndexTest.java
index 439635a9358..f06fd9c0162 100644
--- a/sonar-server/src/test/java/org/sonar/server/search/SearchIndexTest.java
+++ b/sonar-server/src/test/java/org/sonar/server/search/SearchIndexTest.java
@@ -103,7 +103,7 @@ public class SearchIndexTest {
     searchIndex.addMappingFromClasspath("unchecked", "unchecked", resourcePath);
   }
 
-  @Test(expected = IllegalArgumentException.class)
+  @Test(expected = RuntimeException.class)
   public void should_fail_to_load_malformed_mapping() {
     String resourcePath = "/org/sonar/server/search/SearchIndexTest/malformed.json";