From: Simon Brandhof <simon.brandhof@sonarsource.com>
Date: Thu, 28 May 2015 09:02:50 +0000 (+0200)
Subject: Fix definition of core component qualifiers
X-Git-Tag: 5.2-RC1~1795
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=1b771f631c4a73458583718d1fd8b3fcc61d5009;p=sonarqube.git

Fix definition of core component qualifiers
---

diff --git a/server/sonar-server/src/main/java/org/sonar/server/platform/platformlevel/PlatformLevel4.java b/server/sonar-server/src/main/java/org/sonar/server/platform/platformlevel/PlatformLevel4.java
index 847b5234a22..fc5d6d50cab 100644
--- a/server/sonar-server/src/main/java/org/sonar/server/platform/platformlevel/PlatformLevel4.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/platform/platformlevel/PlatformLevel4.java
@@ -343,7 +343,7 @@ public class PlatformLevel4 extends PlatformLevel {
       DistributionAreaChart.class,
       Views.class,
       ResourceTypes.class,
-      DefaultResourceTypes.class,
+      DefaultResourceTypes.get(),
       SettingsChangeNotifier.class,
       PageDecorations.class,
       DefaultResourcePermissions.class,
diff --git a/sonar-batch/src/main/java/org/sonar/batch/bootstrap/BatchComponents.java b/sonar-batch/src/main/java/org/sonar/batch/bootstrap/BatchComponents.java
index f679ae3f8ce..5dd2b76f8b5 100644
--- a/sonar-batch/src/main/java/org/sonar/batch/bootstrap/BatchComponents.java
+++ b/sonar-batch/src/main/java/org/sonar/batch/bootstrap/BatchComponents.java
@@ -84,7 +84,7 @@ public class BatchComponents {
 
   public static Collection all(DefaultAnalysisMode analysisMode) {
     List components = Lists.newArrayList(
-      DefaultResourceTypes.class,
+      DefaultResourceTypes.get(),
 
       // Maven
       MavenProjectBootstrapper.class, MavenProjectConverter.class, MavenProjectBuilder.class,
diff --git a/sonar-core/src/main/java/org/sonar/core/resource/DefaultResourceTypes.java b/sonar-core/src/main/java/org/sonar/core/resource/DefaultResourceTypes.java
index 76e88053609..fcd6ffdab73 100644
--- a/sonar-core/src/main/java/org/sonar/core/resource/DefaultResourceTypes.java
+++ b/sonar-core/src/main/java/org/sonar/core/resource/DefaultResourceTypes.java
@@ -19,9 +19,7 @@
  */
 package org.sonar.core.resource;
 
-import org.sonar.api.ExtensionProvider;
 import org.sonar.api.batch.BatchSide;
-import org.sonar.api.batch.InstantiationStrategy;
 import org.sonar.api.resources.Qualifiers;
 import org.sonar.api.resources.ResourceType;
 import org.sonar.api.resources.ResourceTypeTree;
@@ -29,16 +27,17 @@ import org.sonar.api.server.ServerSide;
 
 @BatchSide
 @ServerSide
-@InstantiationStrategy(InstantiationStrategy.PER_BATCH)
-public final class DefaultResourceTypes extends ExtensionProvider {
+public final class DefaultResourceTypes {
 
   private static final String SUPPORTS_MEASURE_FILTERS = "supportsMeasureFilters";
   private static final String CONFIGURABLE = "configurable";
   private static final String UPDATABLE_KEY = "updatable_key";
 
-  @Override
-  public ResourceTypeTree provide() {
+  private DefaultResourceTypes() {
+    // only static methods
+  }
 
+  public static ResourceTypeTree get() {
     return ResourceTypeTree.builder()
       .addType(ResourceType.builder(Qualifiers.PROJECT)
         .setProperty("deletable", true)
diff --git a/sonar-core/src/test/java/org/sonar/core/resource/DefaultResourceTypesTest.java b/sonar-core/src/test/java/org/sonar/core/resource/DefaultResourceTypesTest.java
index ed418b96709..a09303ff2b9 100644
--- a/sonar-core/src/test/java/org/sonar/core/resource/DefaultResourceTypesTest.java
+++ b/sonar-core/src/test/java/org/sonar/core/resource/DefaultResourceTypesTest.java
@@ -29,7 +29,7 @@ import static org.assertj.core.api.Assertions.assertThat;
 public class DefaultResourceTypesTest {
   @Test
   public void provide_types() {
-    ResourceTypeTree tree = new DefaultResourceTypes().provide();
+    ResourceTypeTree tree = DefaultResourceTypes.get();
 
     assertThat(tree.getTypes()).hasSize(7);
     assertThat(tree.getChildren(Qualifiers.PROJECT)).containsExactly(Qualifiers.MODULE);
@@ -37,7 +37,7 @@ public class DefaultResourceTypesTest {
 
   @Test
   public void projects_should_be_available_for_global_widgets() {
-    ResourceTypeTree tree = new DefaultResourceTypes().provide();
+    ResourceTypeTree tree = DefaultResourceTypes.get();
 
     ResourceType projectResourceType = tree.getTypes().get(0);