From: Javen O'Neal Date: Thu, 22 Sep 2016 07:36:52 +0000 (+0000) Subject: bug 59687: add failing unit test showing that comments when the row that contains... X-Git-Tag: REL_3_16_BETA1~149 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=1d9f92b8ddb4358982aa23036239fcd7036927f8;p=poi.git bug 59687: add failing unit test showing that comments when the row that contains the comment is deleted; patch and file contributed by Greg Woolsey git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1761860 13f79535-47bb-0310-9956-ffa450edef68 --- diff --git a/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFSheet.java b/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFSheet.java index 2c561b222d..34ae2cfc40 100644 --- a/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFSheet.java +++ b/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFSheet.java @@ -2020,4 +2020,22 @@ public final class TestXSSFSheet extends BaseTestXSheet { } } + + // bug 59687: XSSFSheet.RemoveRow doesn't handle row gaps properly when removing row comments + // This test is currently failing (thus expected AssertionError). When this bug is fixed, no error should be thrown. + @Test(expected=AssertionError.class) + public void testRemoveRowWithCommentAndGapAbove() throws IOException { + final Workbook wb = _testDataProvider.openSampleWorkbook("59687.xlsx"); + final Sheet sheet = wb.getSheetAt(0); + + // comment exists + CellAddress commentCellAddress = new CellAddress("A4"); + assertNotNull(sheet.getCellComment(commentCellAddress)); + + assertEquals("Wrong starting # of comments", 1, sheet.getCellComments().size()); + + sheet.removeRow(sheet.getRow(commentCellAddress.getRow())); + + assertEquals("There should not be any comments left!", 0, sheet.getCellComments().size()); + } } diff --git a/test-data/spreadsheet/59687.xlsx b/test-data/spreadsheet/59687.xlsx new file mode 100644 index 0000000000..8ce567fab3 Binary files /dev/null and b/test-data/spreadsheet/59687.xlsx differ