From: Jacek <52388493+jacek-poreda-sonarsource@users.noreply.github.com> Date: Thu, 1 Aug 2019 13:08:41 +0000 (+0200) Subject: Fix test to make it run on mac os (#1977) X-Git-Tag: 8.0~284 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=1feb7a0ef4ff095b9712f891385207b60f4c2e6c;p=sonarqube.git Fix test to make it run on mac os (#1977) * fix test to make it run on mac os --- diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/utils/System2.java b/sonar-plugin-api/src/main/java/org/sonar/api/utils/System2.java index 36dc553a74e..ed4ee20497c 100644 --- a/sonar-plugin-api/src/main/java/org/sonar/api/utils/System2.java +++ b/sonar-plugin-api/src/main/java/org/sonar/api/utils/System2.java @@ -126,6 +126,13 @@ public class System2 { return SystemUtils.IS_OS_WINDOWS; } + /** + * True if this is Mac system. + */ + public boolean isOsMac() { + return SystemUtils.IS_OS_MAC; + } + /** * True if Java 7 or Java 8 runtime environment * diff --git a/sonar-plugin-api/src/test/java/org/sonar/api/utils/System2Test.java b/sonar-plugin-api/src/test/java/org/sonar/api/utils/System2Test.java index 9a8526195eb..ec4d0aac177 100644 --- a/sonar-plugin-api/src/test/java/org/sonar/api/utils/System2Test.java +++ b/sonar-plugin-api/src/test/java/org/sonar/api/utils/System2Test.java @@ -83,6 +83,11 @@ public class System2Test { assertThat(System2.INSTANCE.isOsWindows()).isEqualTo(SystemUtils.IS_OS_WINDOWS); } + @Test + public void testIsOsMac() { + assertThat(System2.INSTANCE.isOsMac()).isEqualTo(SystemUtils.IS_OS_MAC); + } + @Test public void isJavaAtLeast17_always_returns_true() { assertThat(System2.INSTANCE.isJavaAtLeast17()).isTrue(); diff --git a/sonar-scanner-engine/src/test/java/org/sonar/scanner/mediumtest/fs/FileSystemMediumTest.java b/sonar-scanner-engine/src/test/java/org/sonar/scanner/mediumtest/fs/FileSystemMediumTest.java index 29c09f7a81d..70b06029ef1 100644 --- a/sonar-scanner-engine/src/test/java/org/sonar/scanner/mediumtest/fs/FileSystemMediumTest.java +++ b/sonar-scanner-engine/src/test/java/org/sonar/scanner/mediumtest/fs/FileSystemMediumTest.java @@ -36,12 +36,12 @@ import org.junit.rules.TemporaryFolder; import org.sonar.api.CoreProperties; import org.sonar.api.SonarEdition; import org.sonar.api.batch.fs.InputFile; +import org.sonar.api.batch.fs.internal.DefaultInputFile; import org.sonar.api.utils.MessageException; import org.sonar.api.utils.PathUtils; import org.sonar.api.utils.System2; import org.sonar.api.utils.log.LogTester; import org.sonar.api.utils.log.LoggerLevel; -import org.sonar.api.batch.fs.internal.DefaultInputFile; import org.sonar.scanner.mediumtest.AnalysisResult; import org.sonar.scanner.mediumtest.ScannerMediumTester; import org.sonar.xoo.XooPlugin; @@ -823,7 +823,20 @@ public class FileSystemMediumTest { "xources/hello/helloscala.xoo", "testx/ClassOneTest.xoo.scm", "xources/hello/HelloJava.xoo"); - } else { // Other OS are case-sensitive so an exception should be thrown + } else if (System2.INSTANCE.isOsMac()) { + AnalysisResult result = analysis.execute(); + + assertThat(result.inputFiles()).hasSize(8); + assertThat(result.inputFiles()).extractingResultOf("relativePath").containsOnly( + "TESTX/ClassOneTest.xoo.measures", + "XOURCES/hello/helloscala.xoo.measures", + "XOURCES/hello/HelloJava.xoo.measures", + "TESTX/ClassOneTest.xoo", + "XOURCES/hello/HelloJava.xoo.scm", + "XOURCES/hello/helloscala.xoo", + "TESTX/ClassOneTest.xoo.scm", + "XOURCES/hello/HelloJava.xoo"); + } else { thrown.expect(MessageException.class); thrown.expectMessage("The folder 'TESTX' does not exist for 'sample'"); analysis.execute();