From: Jörn Zaefferer Date: Thu, 12 Apr 2012 15:14:03 +0000 (+0200) Subject: Position: Cache Math.abs and Math.max lookups X-Git-Tag: 1.9.0m8~87^2~22 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=2154ca552aa588c8bf5306707ffcddabd1b25820;p=jquery-ui.git Position: Cache Math.abs and Math.max lookups --- diff --git a/ui/jquery.ui.position.js b/ui/jquery.ui.position.js index c87e1d105..c5c02aa1d 100644 --- a/ui/jquery.ui.position.js +++ b/ui/jquery.ui.position.js @@ -228,14 +228,16 @@ $.fn.position = function( options ) { feedback = { horizontal: right < 0 ? "left" : left > 0 ? "right" : "center", vertical: bottom < 0 ? "top" : top > 0 ? "bottom" : "middle" - }; - if ( targetWidth < elemWidth && Math.abs( left + right ) < targetWidth ) { + }, + max = Math.max, + abs = Math.abs; + if ( targetWidth < elemWidth && abs( left + right ) < targetWidth ) { feedback.horizontal = "center"; } - if ( targetHeight < elemHeight && Math.abs( top + bottom ) < targetHeight ) { + if ( targetHeight < elemHeight && abs( top + bottom ) < targetHeight ) { feedback.vertical = "middle"; } - if ( Math.max( Math.abs( left ), Math.abs( right ) ) > Math.max( Math.abs( top ), Math.abs( bottom ) ) ) { + if ( max( abs( left ), abs( right ) ) > max( abs( top ), abs( bottom ) ) ) { feedback.important = "horizontal"; } else { feedback.important = "vertical";