From: Scott González <scott.gonzalez@gmail.com>
Date: Fri, 22 Feb 2013 14:15:43 +0000 (-0500)
Subject: Spinner: Call _stop() on blur. Fixes #9112 - Spinner keeps changing after losing... 
X-Git-Tag: 1.10.2~41
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=2348fb8eb9ec1297a2588a23cf3447c5374bcb21;p=jquery-ui.git

Spinner: Call _stop() on blur. Fixes #9112 - Spinner keeps changing after losing focus.
---

diff --git a/tests/unit/spinner/spinner_core.js b/tests/unit/spinner/spinner_core.js
index a1179bb35..bea5f9122 100644
--- a/tests/unit/spinner/spinner_core.js
+++ b/tests/unit/spinner/spinner_core.js
@@ -80,6 +80,33 @@ test( "keydown PAGE_DOWN on input, decreases value not less than min", function(
 	equal( element.val(), 20 );
 });
 
+asyncTest( "blur input while spinning with UP", function() {
+	expect( 3 );
+	var value,
+		element = $( "#spin" ).val( 10 ).spinner();
+
+	function step1() {
+		element.simulate( "keydown", { keyCode: $.ui.keyCode.UP } );
+		equal( element.val(), 11 );
+		setTimeout( step2, 750 );
+	}
+
+	function step2() {
+		value = element.val();
+		ok( value > 11, "repeating while key is down" );
+		element[0].blur();
+		setTimeout( step3, 250 );
+	}
+
+	function step3() {
+		equal( element.val(), value, "stopped repeating on blur" );
+		start();
+	}
+
+	element[ 0 ].focus();
+	setTimeout( step1 );
+});
+
 test( "mouse click on up button, increases value not greater than max", function() {
 	expect( 3 );
 	var element = $( "#spin" ).val( 18 ).spinner({
diff --git a/ui/jquery.ui.spinner.js b/ui/jquery.ui.spinner.js
index c14ef9370..644b65239 100644
--- a/ui/jquery.ui.spinner.js
+++ b/ui/jquery.ui.spinner.js
@@ -102,6 +102,7 @@ $.widget( "ui.spinner", {
 				return;
 			}
 
+			this._stop();
 			this._refresh();
 			if ( this.previous !== this.element.val() ) {
 				this._trigger( "change", event );