From: Godin <mandrikov@gmail.com>
Date: Mon, 6 Dec 2010 15:48:20 +0000 (+0000)
Subject: Improve ViolationsDecoratorTest
X-Git-Tag: 2.6~397
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=2728a4dacdd779e797ef4ef0f26d17db7c0adb0a;p=sonarqube.git

Improve ViolationsDecoratorTest
---

diff --git a/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/ViolationsDecoratorTest.java b/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/ViolationsDecoratorTest.java
index eb370afdad9..7ea119a24ac 100644
--- a/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/ViolationsDecoratorTest.java
+++ b/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/ViolationsDecoratorTest.java
@@ -115,11 +115,11 @@ public class ViolationsDecoratorTest {
 
     decorator.decorate(resource, context);
 
-    verify(context).saveMeasure(argThat(new IsRuleMeasure(CoreMetrics.VIOLATIONS, null, null, RulePriority.BLOCKER, 0.0)));
-    verify(context).saveMeasure(argThat(new IsRuleMeasure(CoreMetrics.VIOLATIONS, null, null, RulePriority.CRITICAL, 2.0)));
-    verify(context).saveMeasure(argThat(new IsRuleMeasure(CoreMetrics.VIOLATIONS, null, null, RulePriority.MAJOR, 1.0)));
-    verify(context).saveMeasure(argThat(new IsRuleMeasure(CoreMetrics.VIOLATIONS, null, null, RulePriority.MINOR, 1.0)));
-    verify(context).saveMeasure(argThat(new IsRuleMeasure(CoreMetrics.VIOLATIONS, null, null, RulePriority.INFO, 0.0)));
+    verify(context).saveMeasure(argThat(new IsRuleMeasure(CoreMetrics.VIOLATIONS, null, RulePriority.BLOCKER, 0.0)));
+    verify(context).saveMeasure(argThat(new IsRuleMeasure(CoreMetrics.VIOLATIONS, null, RulePriority.CRITICAL, 2.0)));
+    verify(context).saveMeasure(argThat(new IsRuleMeasure(CoreMetrics.VIOLATIONS, null, RulePriority.MAJOR, 1.0)));
+    verify(context).saveMeasure(argThat(new IsRuleMeasure(CoreMetrics.VIOLATIONS, null, RulePriority.MINOR, 1.0)));
+    verify(context).saveMeasure(argThat(new IsRuleMeasure(CoreMetrics.VIOLATIONS, null, RulePriority.INFO, 0.0)));
 
     verify(context).saveMeasure(argThat(new IsMeasure(CoreMetrics.BLOCKER_VIOLATIONS, 0.0)));
     verify(context).saveMeasure(argThat(new IsMeasure(CoreMetrics.CRITICAL_VIOLATIONS, 2.0)));
@@ -128,6 +128,17 @@ public class ViolationsDecoratorTest {
     verify(context).saveMeasure(argThat(new IsMeasure(CoreMetrics.INFO_VIOLATIONS, 0.0)));
   }
 
+  @Test
+  public void ruleViolations() {
+    when(context.getViolations()).thenReturn(createViolations());
+
+    decorator.decorate(resource, context);
+
+    verify(context).saveMeasure(argThat(new IsRuleMeasure(CoreMetrics.VIOLATIONS, ruleA1, RulePriority.CRITICAL, 2.0)));
+    verify(context).saveMeasure(argThat(new IsRuleMeasure(CoreMetrics.VIOLATIONS, ruleA2, RulePriority.MAJOR, 1.0)));
+    verify(context).saveMeasure(argThat(new IsRuleMeasure(CoreMetrics.VIOLATIONS, ruleB1, RulePriority.MINOR, 1.0)));
+  }
+
   private List<Violation> createViolations() {
     List<Violation> violations = new ArrayList<Violation>();
     violations.add(Violation.create(ruleA1, resource).setPriority(RulePriority.CRITICAL));
diff --git a/sonar-plugin-api/src/test/java/org/sonar/api/test/IsRuleMeasure.java b/sonar-plugin-api/src/test/java/org/sonar/api/test/IsRuleMeasure.java
index 14dadb15f87..364ea4ab3bd 100644
--- a/sonar-plugin-api/src/test/java/org/sonar/api/test/IsRuleMeasure.java
+++ b/sonar-plugin-api/src/test/java/org/sonar/api/test/IsRuleMeasure.java
@@ -36,13 +36,23 @@ public class IsRuleMeasure extends BaseMatcher<Measure> {
   private RulePriority priority = null;
   private Double value = null;
 
-  public IsRuleMeasure(Metric metric, Rule rule, Integer category, RulePriority priority, Double value) {
+  public IsRuleMeasure(Metric metric, Rule rule, RulePriority priority, Double value) {
     this.metric = metric;
     this.rule = rule;
     this.priority = priority;
     this.value = value;
   }
 
+  /**
+   * @deprecated since 2.5
+   *             category not used anymore - see http://jira.codehaus.org/browse/SONAR-2007 , so use
+   *             {@link #IsRuleMeasure(Metric, Rule, RulePriority, Double)} instead
+   */
+  @Deprecated
+  public IsRuleMeasure(Metric metric, Rule rule, Integer category, RulePriority priority, Double value) {
+    this(metric, rule, priority, value);
+  }
+
   public boolean matches(Object o) {
     if (!(o instanceof RuleMeasure)) {
       return false;