From: Léo Geoffroy <leo.geoffroy@sonarsource.com>
Date: Thu, 1 Jun 2023 08:30:02 +0000 (+0200)
Subject: SONAR-18856 Fix code smells and TODOs
X-Git-Tag: 10.1.0.73491~158
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=2a718cb91427aeb3ddb0adb35c15f81cee18461f;p=sonarqube.git

SONAR-18856 Fix code smells and TODOs
---

diff --git a/server/sonar-db-migration/src/main/java/org/sonar/server/platform/db/migration/version/v101/PopulateReportSubscriptions.java b/server/sonar-db-migration/src/main/java/org/sonar/server/platform/db/migration/version/v101/PopulateReportSubscriptions.java
index 63b197577ce..12bfa4d129f 100644
--- a/server/sonar-db-migration/src/main/java/org/sonar/server/platform/db/migration/version/v101/PopulateReportSubscriptions.java
+++ b/server/sonar-db-migration/src/main/java/org/sonar/server/platform/db/migration/version/v101/PopulateReportSubscriptions.java
@@ -26,7 +26,7 @@ import org.sonar.server.platform.db.migration.step.DataChange;
 import org.sonar.server.platform.db.migration.step.MassUpdate;
 
 public class PopulateReportSubscriptions extends DataChange {
-  // TODO should we add a inner join on users to not transfer values of non-existent users?
+
   private static final String SELECT_QUERY = """
     SELECT port.uuid as portfolioUuid, pb.uuid as branchUuid, p.user_uuid as userUuid
     FROM properties p
diff --git a/server/sonar-webserver-auth/src/main/java/org/sonar/server/user/ServerUserSession.java b/server/sonar-webserver-auth/src/main/java/org/sonar/server/user/ServerUserSession.java
index 518b710e5f4..dfabf778740 100644
--- a/server/sonar-webserver-auth/src/main/java/org/sonar/server/user/ServerUserSession.java
+++ b/server/sonar-webserver-auth/src/main/java/org/sonar/server/user/ServerUserSession.java
@@ -199,7 +199,7 @@ public class ServerUserSession extends AbstractUserSession {
   @Override
   public <T extends EntityDto> List<T> keepAuthorizedEntities(String permission, Collection<T> projects) {
     Set<String> projectsUuids = projects.stream().map(EntityDto::getUuid).collect(Collectors.toSet());
-    // TODO
+    // TODO in SONAR-19445
     Set<String> authorizedProjectsUuids = keepProjectsUuidsByPermission(permission, projectsUuids);
 
     return projects.stream()
diff --git a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/component/ComponentUpdater.java b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/component/ComponentUpdater.java
index bf4136b08a1..c905660861a 100644
--- a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/component/ComponentUpdater.java
+++ b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/component/ComponentUpdater.java
@@ -150,12 +150,12 @@ public class ComponentUpdater {
       dbClient.portfolioDao().insert(dbSession, portfolioDto);
     }
 
-    // TODO permissions: probably we want to apply it to the projectDto or portfolioDto
+    // TODO SONAR-19445: probably we want to apply it to the projectDto or portfolioDto
     permissionTemplateService.applyDefaultToNewComponent(dbSession, componentDto, userUuid);
     return new ComponentCreationData(componentDto, mainBranch, projectDto);
   }
 
-  // TODO, when working on permissions, maybe we could remove the last argument from this method
+  // TODO SONAR-19445, when working on permissions, maybe we could remove the last argument from this method
   private void addToFavourites(DbSession dbSession, ProjectDto projectDto, @Nullable String userUuid, @Nullable String userLogin, ComponentDto componentDto) {
     if (permissionTemplateService.hasDefaultTemplateWithPermissionOnProjectCreator(dbSession, componentDto)) {
       favoriteUpdater.add(dbSession, projectDto, userUuid, userLogin, false);