From: Stephane Gamard <stephane.gamard@searchbox.com>
Date: Wed, 14 May 2014 13:24:32 +0000 (+0200)
Subject: Fixed inheritance when parent_id is null in DTO
X-Git-Tag: 4.4-RC1~1076
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=2c84317ae28451a627021355d061d2f549149a73;p=sonarqube.git

Fixed inheritance when parent_id is null in DTO
---

diff --git a/sonar-server/src/main/java/org/sonar/server/rule2/ws/SearchAction.java b/sonar-server/src/main/java/org/sonar/server/rule2/ws/SearchAction.java
index 4125a220432..5974374eab3 100644
--- a/sonar-server/src/main/java/org/sonar/server/rule2/ws/SearchAction.java
+++ b/sonar-server/src/main/java/org/sonar/server/rule2/ws/SearchAction.java
@@ -243,8 +243,12 @@ public class SearchAction implements RequestHandler {
           .beginObject()
           .prop("key",activeRule.key().toString())
           .prop("inherit", activeRule.inheritance().name())
-          .prop("severity", activeRule.severity())
-          .prop("parent", activeRule.parentKey().toString())
+          .prop("severity", activeRule.severity());
+        if(activeRule.parentKey() != null){
+          json.prop("parent",activeRule.parentKey().toString());
+        }
+
+        json
           .name("params").beginArray();
         for (Map.Entry<String, String> param : activeRule.params().entrySet()) {
           json.beginObject()
diff --git a/sonar-server/src/test/java/org/sonar/server/rule2/ws/RulesWebServiceTest.java b/sonar-server/src/test/java/org/sonar/server/rule2/ws/RulesWebServiceTest.java
index c5ac8dd3f56..08ecaf0a911 100644
--- a/sonar-server/src/test/java/org/sonar/server/rule2/ws/RulesWebServiceTest.java
+++ b/sonar-server/src/test/java/org/sonar/server/rule2/ws/RulesWebServiceTest.java
@@ -231,7 +231,7 @@ public class RulesWebServiceTest {
 
   private ActiveRuleDto  newActiveRule(QualityProfileDto profile, RuleDto rule) {
     return ActiveRuleDto.createFor(profile, rule)
-      .setInheritance("none")
+      .setInheritance("NONE")
       .setSeverity("BLOCKER");
   }
 }
\ No newline at end of file
diff --git a/sonar-server/src/test/resources/org/sonar/server/rule2/ws/RulesWebServiceTest/search_active_rules.json b/sonar-server/src/test/resources/org/sonar/server/rule2/ws/RulesWebServiceTest/search_active_rules.json
index 84648237109..fc63e918b39 100644
--- a/sonar-server/src/test/resources/org/sonar/server/rule2/ws/RulesWebServiceTest/search_active_rules.json
+++ b/sonar-server/src/test/resources/org/sonar/server/rule2/ws/RulesWebServiceTest/search_active_rules.json
@@ -1,4 +1,4 @@
-{"total": 1,"p":1,"ps":25, "rules": [
+{"total": 1, "p": 1, "ps": 25, "rules": [
     {
         "key": "java:S001",
         "repo": "java",
@@ -15,8 +15,7 @@
         "actives": [
             {
                 "key": "My Profile:java:java:S001",
-                "inherit": "none",
-                "override": false,
+                "inherit": "NONE",
                 "severity": "BLOCKER",
                 "params": []
             }
diff --git a/sonar-server/src/test/resources/org/sonar/server/rule2/ws/RulesWebServiceTest/search_active_rules_params.json b/sonar-server/src/test/resources/org/sonar/server/rule2/ws/RulesWebServiceTest/search_active_rules_params.json
index 54584e7cdf4..853aac8c4d2 100644
--- a/sonar-server/src/test/resources/org/sonar/server/rule2/ws/RulesWebServiceTest/search_active_rules_params.json
+++ b/sonar-server/src/test/resources/org/sonar/server/rule2/ws/RulesWebServiceTest/search_active_rules_params.json
@@ -21,8 +21,7 @@
         "actives": [
             {
                 "key": "My Profile:java:java:S001",
-                "inherit": "none",
-                "override": false,
+                "inherit": "NONE",
                 "severity": "BLOCKER",
                 "params": [
                     {