From: Arthur Schiwon <blizzz@arthur-schiwon.de>
Date: Tue, 4 Apr 2017 11:12:29 +0000 (+0200)
Subject: fix fseek against string not resource by removing append support
X-Git-Tag: v12.0.0beta1~224^2
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=30c95b51fba347e4855e5873c6cde59fcca7f2c6;p=nextcloud-server.git

fix fseek against string not resource by removing append support

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
---

diff --git a/apps/files_external/lib/Lib/Storage/Swift.php b/apps/files_external/lib/Lib/Storage/Swift.php
index 5fec278ef3d..105d1073ae6 100644
--- a/apps/files_external/lib/Lib/Storage/Swift.php
+++ b/apps/files_external/lib/Lib/Storage/Swift.php
@@ -373,6 +373,10 @@ class Swift extends \OC\Files\Storage\Common {
 		$path = $this->normalizePath($path);
 
 		switch ($mode) {
+			case 'a':
+			case 'ab':
+			case 'a+':
+				return false;
 			case 'r':
 			case 'rb':
 				try {
@@ -395,12 +399,9 @@ class Swift extends \OC\Files\Storage\Common {
 				}
 			case 'w':
 			case 'wb':
-			case 'a':
-			case 'ab':
 			case 'r+':
 			case 'w+':
 			case 'wb+':
-			case 'a+':
 			case 'x':
 			case 'x+':
 			case 'c':
@@ -419,10 +420,6 @@ class Swift extends \OC\Files\Storage\Common {
 					}
 					$source = $this->fopen($path, 'r');
 					file_put_contents($tmpFile, $source);
-					// Seek to end if required
-					if ($mode[0] === 'a') {
-						fseek($tmpFile, 0, SEEK_END);
-					}
 				}
 				$handle = fopen($tmpFile, $mode);
 				return CallbackWrapper::wrap($handle, null, null, function () use ($path, $tmpFile) {