From: Glen Mazza Date: Sat, 17 Jan 2004 22:02:03 +0000 (+0000) Subject: Bug 25873 (from Finn Bock): Minor code cleanup issues. X-Git-Tag: Root_Temp_KnuthStylePageBreaking~911 X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=33220ae4076f8d330c6bfbf7e093d68512396dbf;p=xmlgraphics-fop.git Bug 25873 (from Finn Bock): Minor code cleanup issues. git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@197214 13f79535-47bb-0310-9956-ffa450edef68 --- diff --git a/src/java/org/apache/fop/datatypes/Keep.java b/src/java/org/apache/fop/datatypes/Keep.java index 3c68ad5e6..09fb31483 100644 --- a/src/java/org/apache/fop/datatypes/Keep.java +++ b/src/java/org/apache/fop/datatypes/Keep.java @@ -51,7 +51,7 @@ package org.apache.fop.datatypes; import org.apache.fop.fo.Property; -import org.apache.fop.fo.Constants; + /** * XSL FO Keep Property datatype (keep-together, etc) diff --git a/src/java/org/apache/fop/datatypes/LengthPair.java b/src/java/org/apache/fop/datatypes/LengthPair.java index ac2de9c8b..aeb7e1e45 100644 --- a/src/java/org/apache/fop/datatypes/LengthPair.java +++ b/src/java/org/apache/fop/datatypes/LengthPair.java @@ -51,7 +51,7 @@ package org.apache.fop.datatypes; import org.apache.fop.fo.Property; -import org.apache.fop.fo.Constants; + /** * Models a pair of lengths, one specifiying the dimensions for the diff --git a/src/java/org/apache/fop/fo/flow/Leader.java b/src/java/org/apache/fop/fo/flow/Leader.java index 55cb47fb6..bcb745399 100644 --- a/src/java/org/apache/fop/fo/flow/Leader.java +++ b/src/java/org/apache/fop/fo/flow/Leader.java @@ -62,7 +62,6 @@ import org.apache.fop.fo.properties.CommonBackground; import org.apache.fop.fo.properties.CommonBorderAndPadding; import org.apache.fop.fo.properties.CommonMarginInline; import org.apache.fop.fo.properties.CommonRelativePosition; -import org.apache.fop.fo.properties.FOPropertyMapping; import org.apache.fop.fonts.Font; /** @@ -163,9 +162,8 @@ public class Leader extends FObjMixed { } - public int getLength(String prop, int dim) { + public int getLength(int propId, int dim) { int length; - int propId = FOPropertyMapping.getPropertyId(prop); Length maxlength = propertyList.get(propId).getLength(); if (maxlength instanceof PercentLength) { length = (int)(((PercentLength)maxlength).value() diff --git a/src/java/org/apache/fop/layoutmgr/AddLMVisitor.java b/src/java/org/apache/fop/layoutmgr/AddLMVisitor.java index dc3ac02ac..c854c1635 100644 --- a/src/java/org/apache/fop/layoutmgr/AddLMVisitor.java +++ b/src/java/org/apache/fop/layoutmgr/AddLMVisitor.java @@ -356,9 +356,9 @@ public class AddLMVisitor implements FOTreeVisitor { public MinOptMax getLeaderAllocIPD(Leader node, int ipd) { // length of the leader - int opt = node.getLength("leader-length.optimum", ipd); - int min = node.getLength("leader-length.minimum", ipd); - int max = node.getLength("leader-length.maximum", ipd); + int opt = node.getLength(Constants.PR_LEADER_LENGTH | Constants.CP_OPTIMUM, ipd); + int min = node.getLength(Constants.PR_LEADER_LENGTH | Constants.CP_MINIMUM, ipd); + int max = node.getLength(Constants.PR_LEADER_LENGTH | Constants.CP_MAXIMUM, ipd); return new MinOptMax(min, opt, max); }