From: Marc Englund <marc.englund@itmill.com>
Date: Fri, 2 Nov 2007 08:45:43 +0000 (+0000)
Subject: Don't paint the null selection item if nullselection is not allowed.
X-Git-Tag: 6.7.0.beta1~5708
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=351c76dd06dbf2060f4492042e4b66e1b45f89dd;p=vaadin-framework.git

Don't paint the null selection item if nullselection is not allowed.

svn changeset:2670/svn branch:trunk
---

diff --git a/src/com/itmill/toolkit/ui/AbstractSelect.java b/src/com/itmill/toolkit/ui/AbstractSelect.java
index f86bd94c52..939cdd248d 100644
--- a/src/com/itmill/toolkit/ui/AbstractSelect.java
+++ b/src/com/itmill/toolkit/ui/AbstractSelect.java
@@ -297,8 +297,8 @@ public abstract class AbstractSelect extends AbstractField implements
 		int keyIndex = 0;
 		// Support for external null selection item id
 		Collection ids = getItemIds();
-		if (getNullSelectionItemId() != null
-				&& (!ids.contains(getNullSelectionItemId()))) {
+		if (isNullSelectionAllowed() && getNullSelectionItemId() != null
+				&& !ids.contains(getNullSelectionItemId())) {
 			// Gets the option attribute values
 			Object id = getNullSelectionItemId();
 			String key = this.itemIdMapper.key(id);
@@ -324,6 +324,12 @@ public abstract class AbstractSelect extends AbstractField implements
 		while (i.hasNext()) {
 			// Gets the option attribute values
 			Object id = i.next();
+			if (!isNullSelectionAllowed() && id != null
+					&& id.equals(getNullSelectionItemId())) {
+				// Remove item if it's the null selection item but null
+				// selection is not allowed
+				continue;
+			}
 			String key = this.itemIdMapper.key(id);
 			String caption = getItemCaption(id);
 			Resource icon = getItemIcon(id); // Paints the option
@@ -862,7 +868,8 @@ public abstract class AbstractSelect extends AbstractField implements
 	 */
 	public void setMultiSelect(boolean multiSelect) {
 		if (multiSelect && getNullSelectionItemId() != null) {
-			throw new IllegalStateException();
+			throw new IllegalStateException(
+					"Multiselect and NullSelectionItemId can not be set at the same time.");
 		}
 		if (multiSelect != this.multiSelect) {
 
@@ -1496,7 +1503,8 @@ public abstract class AbstractSelect extends AbstractField implements
 	 */
 	public void setNullSelectionItemId(Object nullSelectionItemId) {
 		if (nullSelectionItemId != null && isMultiSelect()) {
-			throw new IllegalStateException();
+			throw new IllegalStateException(
+					"Multiselect and NullSelectionItemId can not be set at the same time.");
 		}
 		this.nullSelectionItemId = nullSelectionItemId;
 	}