From: Monty Taylor <mordred@inaugust.com>
Date: Wed, 17 Jul 2019 17:34:13 +0000 (-0400)
Subject: Update User.NumRepos atomically in createRepository (#7493)
X-Git-Tag: v1.10.0-rc1~379
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=361607d83109014a8dfd40e97c6f95a0e869dca3;p=gitea.git

Update User.NumRepos atomically in createRepository (#7493)

The update call on the user call races if there is more than one
repository creation concurrently, leading to incorrect count of
repos. Split things in two, so that we call the update for last
visibility (which isn't problematic if it races, since it can only
ever be best-effort anyway). This way we can atomically increment
the count of repos.
---

diff --git a/models/repo.go b/models/repo.go
index fc5f81eb5c..c60488844c 100644
--- a/models/repo.go
+++ b/models/repo.go
@@ -1306,13 +1306,17 @@ func createRepository(e *xorm.Session, doer, u *User, repo *Repository) (err err
 		return err
 	}
 
-	u.NumRepos++
 	// Remember visibility preference.
 	u.LastRepoVisibility = repo.IsPrivate
-	if err = updateUser(e, u); err != nil {
+	if err = updateUserCols(e, u, "last_repo_visibility"); err != nil {
 		return fmt.Errorf("updateUser: %v", err)
 	}
 
+	if _, err = e.Incr("num_repos").ID(u.ID).Update(new(User)); err != nil {
+		return fmt.Errorf("increment user total_repos: %v", err)
+	}
+	u.NumRepos++
+
 	// Give access to all members in owner team.
 	if u.IsOrganization() {
 		t, err := u.getOwnerTeam(e)