From: David Cho-Lerat <david.cho-lerat@sonarsource.com>
Date: Mon, 29 Jul 2024 08:45:00 +0000 (+0200)
Subject: SONAR-22303 Fix aria-label misuse (Deque issue #1742007)
X-Git-Tag: 10.7.0.96327~283
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=379a7d804e0d8aaeeab6d6e226ba25501ac1963f;p=sonarqube.git

SONAR-22303 Fix aria-label misuse (Deque issue #1742007)
---

diff --git a/server/sonar-web/src/main/js/app/components/nav/global/MainSonarQubeBar.tsx b/server/sonar-web/src/main/js/app/components/nav/global/MainSonarQubeBar.tsx
index 05e799562df..3ecb9d32f1b 100644
--- a/server/sonar-web/src/main/js/app/components/nav/global/MainSonarQubeBar.tsx
+++ b/server/sonar-web/src/main/js/app/components/nav/global/MainSonarQubeBar.tsx
@@ -32,7 +32,9 @@ function LogoWithAriaText() {
   const customLogoUrl = settings[GlobalSettingKeys.LogoUrl];
   const customLogoWidth = settings[GlobalSettingKeys.LogoWidth] ?? DEFAULT_CUSTOM_LOGO_WIDTH_IN_PX;
 
-  const title = translate('layout.nav.home_logo_alt');
+  const title = customLogoUrl
+    ? translate('layout.nav.home_logo_alt')
+    : translate('layout.nav.home_sonarqube_logo_alt');
 
   return (
     <div aria-label={title} role="img">
diff --git a/sonar-core/src/main/resources/org/sonar/l10n/core.properties b/sonar-core/src/main/resources/org/sonar/l10n/core.properties
index 1d28a55a9ba..d8dff3b0c34 100644
--- a/sonar-core/src/main/resources/org/sonar/l10n/core.properties
+++ b/sonar-core/src/main/resources/org/sonar/l10n/core.properties
@@ -585,6 +585,7 @@ layout.settings.VW=Portfolio Settings
 layout.settings.SVW=Portfolio Settings
 layout.security_reports=Security Reports
 layout.nav.home_logo_alt=Logo, link to homepage
+layout.nav.home_sonarqube_logo_alt=SonarQube logo, link to homepage
 layout.must_be_configured=This will be available once your project is configured and analyzed.
 layout.all_project_must_be_accessible=You need access to all projects within this {0} to access it.