From: Jean-Philippe Lang <jp_lang@yahoo.fr>
Date: Thu, 14 Feb 2013 22:13:49 +0000 (+0000)
Subject: Code cleanup.
X-Git-Tag: 2.3.0~140
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=3c3ac3c6eeba2fa206cdee0ea184bd28eba67ea7;p=redmine.git

Code cleanup.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11375 e93f8b46-1217-0410-a6f0-8f06a7374b81
---

diff --git a/app/models/user.rb b/app/models/user.rb
index e97d01a7c..696a2a203 100644
--- a/app/models/user.rb
+++ b/app/models/user.rb
@@ -156,19 +156,13 @@ class User < Principal
     login = login.to_s
     password = password.to_s
 
-    # Make sure no one can sign in with an empty password
-    return nil if password.empty?
+    # Make sure no one can sign in with an empty login or password
+    return nil if login.empty? || password.empty?
     user = find_by_login(login)
     if user
       # user is already in local database
-      return nil if !user.active?
-      if user.auth_source
-        # user has an external authentication method
-        return nil unless user.auth_source.authenticate(login, password)
-      else
-        # authentication with local password
-        return nil unless user.check_password?(password)
-      end
+      return nil unless user.active?
+      return nil unless user.check_password?(password)
     else
       # user is not yet registered, try to authenticate with available sources
       attrs = AuthSource.authenticate(login, password)