From: PJ Fanning <fanningpj@apache.org>
Date: Thu, 26 May 2022 09:15:43 +0000 (+0000)
Subject: small refactor
X-Git-Tag: REL_5_2_3~291
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=3d57a45f6581258e88c0de6e8d7deafc82952145;p=poi.git

small refactor

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1901275 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/poi/src/main/java/org/apache/poi/ss/formula/functions/DStdev.java b/poi/src/main/java/org/apache/poi/ss/formula/functions/DStdev.java
index 97bd2b31f0..7aca88a3cb 100644
--- a/poi/src/main/java/org/apache/poi/ss/formula/functions/DStdev.java
+++ b/poi/src/main/java/org/apache/poi/ss/formula/functions/DStdev.java
@@ -30,13 +30,12 @@ import java.util.ArrayList;
  * Gets the standard deviation value of a column in an area with given conditions.
  */
 public final class DStdev implements IDStarAlgorithm {
-    private final ArrayList<Double> values = new ArrayList<>();
+    private final ArrayList<NumericValueEval> values = new ArrayList<>();
 
     @Override
     public boolean processMatch(ValueEval eval) {
         if (eval instanceof NumericValueEval) {
-            final double val = ((NumericValueEval)eval).getNumberValue();
-            values.add(val);
+            values.add((NumericValueEval) eval);
         }
         return true;
     }
@@ -45,8 +44,8 @@ public final class DStdev implements IDStarAlgorithm {
     public ValueEval getResult() {
         final double[] array = new double[values.size()];
         int pos = 0;
-        for (Double d : values) {
-            array[pos++] = d;
+        for (NumericValueEval d : values) {
+            array[pos++] = d.getNumberValue();
         }
         final double stdev = StatsLib.stdev(array);
         return new NumberEval(new BigDecimal(NumberToTextConverter.toText(stdev)).doubleValue());
diff --git a/poi/src/main/java/org/apache/poi/ss/formula/functions/DVar.java b/poi/src/main/java/org/apache/poi/ss/formula/functions/DVar.java
index 51e72301a2..fdd6c5db82 100644
--- a/poi/src/main/java/org/apache/poi/ss/formula/functions/DVar.java
+++ b/poi/src/main/java/org/apache/poi/ss/formula/functions/DVar.java
@@ -30,13 +30,12 @@ import java.util.ArrayList;
  * Gets the variance value of a column in an area with given conditions.
  */
 public final class DVar implements IDStarAlgorithm {
-    private final ArrayList<Double> values = new ArrayList<>();
+    private final ArrayList<NumericValueEval> values = new ArrayList<>();
 
     @Override
     public boolean processMatch(ValueEval eval) {
         if (eval instanceof NumericValueEval) {
-            final double val = ((NumericValueEval)eval).getNumberValue();
-            values.add(val);
+            values.add((NumericValueEval) eval);
         }
         return true;
     }
@@ -45,8 +44,8 @@ public final class DVar implements IDStarAlgorithm {
     public ValueEval getResult() {
         final double[] array = new double[values.size()];
         int pos = 0;
-        for (Double d : values) {
-            array[pos++] = d;
+        for (NumericValueEval d : values) {
+            array[pos++] = d.getNumberValue();
         }
         final double var = StatsLib.var(array);
         return new NumberEval(new BigDecimal(NumberToTextConverter.toText(var)).doubleValue());