From: Julien Lancelot <julien.lancelot@gmail.com>
Date: Fri, 12 Jul 2013 14:23:22 +0000 (+0200)
Subject: Remove option color in format_variation as it this option is always activated and... 
X-Git-Tag: 3.7~135
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=3f2feee011facb6cc4267a805b6821cbf14eee15;p=sonarqube.git

Remove option color in format_variation as it this option is always activated and can never been deactivate
---

diff --git a/sonar-server/src/main/webapp/WEB-INF/app/helpers/application_helper.rb b/sonar-server/src/main/webapp/WEB-INF/app/helpers/application_helper.rb
index f82cbee29b6..2bea966249b 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/helpers/application_helper.rb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/helpers/application_helper.rb
@@ -486,7 +486,6 @@ module ApplicationHelper
   # Format variation value
   #
   # === Optional parameters
-  # * color: true|false. Default is true.
   # * period: integer between 1 and 5. By default the index is defined by the dashboard variation select-box
   # * style: light|normal|none. Default is normal (parenthesis + bold)
   #
@@ -509,18 +508,15 @@ module ApplicationHelper
         end
 
         formatted_val= m.format_numeric_value(val, :variation => true)
-        css_class=''
-        if options[:color]||true
-          css_class='var'
-          if m.metric.qualitative?
-            factor=m.metric.direction * val
-            if factor>0
-              # better
-              css_class='varb'
-            elsif factor<0
-              # worst
-              css_class='varw'
-            end
+        css_class='var'
+        if m.metric.qualitative?
+          factor=m.metric.direction * val
+          if factor>0
+            # better
+            css_class='varb'
+          elsif factor<0
+            # worst
+            css_class='varw'
           end
         end