From: Javen O'Neal <onealj@apache.org>
Date: Thu, 7 Jul 2016 23:00:07 +0000 (+0000)
Subject: add crude line-coverage tests for setDebugEvaluationOutputForNextEval and setIgnoreMi... 
X-Git-Tag: REL_3_15_BETA3~162
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=417868e70cef5bc65abaf8887b5bc4f3653c4e92;p=poi.git

add crude line-coverage tests for setDebugEvaluationOutputForNextEval and setIgnoreMissingWorkbooks

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1751841 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/src/java/org/apache/poi/ss/formula/WorkbookEvaluator.java b/src/java/org/apache/poi/ss/formula/WorkbookEvaluator.java
index 43375eff80..3fad35edc0 100644
--- a/src/java/org/apache/poi/ss/formula/WorkbookEvaluator.java
+++ b/src/java/org/apache/poi/ss/formula/WorkbookEvaluator.java
@@ -113,6 +113,16 @@ public final class WorkbookEvaluator {
 
     private boolean _ignoreMissingWorkbooks = false;
 
+    /**
+     * whether print detailed messages about the next formula evaluation
+     */
+    private boolean dbgEvaluationOutputForNextEval = false;
+
+    // special logger for formula evaluation output (because of possibly very large output)
+    private final POILogger EVAL_LOG = POILogFactory.getLogger("POI.FormulaEval");
+    // current indent level for evalution; negative value for no output
+    private int dbgEvaluationOutputIndent = -1;
+
     /**
      * @param udfFinder pass <code>null</code> for default (AnalysisToolPak only)
      */
@@ -408,17 +418,8 @@ public final class WorkbookEvaluator {
     }
 
 
-    /**
-     * whether print detailed messages about the next formula evaluation
-     */
-    private boolean dbgEvaluationOutputForNextEval = false;
-
-    // special logger for formula evaluation output (because of possibly very large output)
-    private final POILogger EVAL_LOG = POILogFactory.getLogger("POI.FormulaEval");
-    // current indent level for evalution; negative value for no output
-    private int dbgEvaluationOutputIndent = -1;
-
     // visibility raised for testing
+    @Internal
     /* package */ ValueEval evaluateFormula(OperationEvaluationContext ec, Ptg[] ptgs) {
 
         String dbgIndentStr = "";        // always init. to non-null just for defensive avoiding NPE
diff --git a/src/testcases/org/apache/poi/ss/formula/TestWorkbookEvaluator.java b/src/testcases/org/apache/poi/ss/formula/TestWorkbookEvaluator.java
index e9f2dc5c39..c97face949 100644
--- a/src/testcases/org/apache/poi/ss/formula/TestWorkbookEvaluator.java
+++ b/src/testcases/org/apache/poi/ss/formula/TestWorkbookEvaluator.java
@@ -18,7 +18,9 @@
 package org.apache.poi.ss.formula;
 
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertSame;
+import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
 
 import java.io.IOException;
@@ -302,6 +304,32 @@ public class TestWorkbookEvaluator {
         
         wb.close();
     }
+
+    @Test
+    public void testIgnoreMissingWorkbooks() {
+        // TODO: update this test for meaningful functional behavior
+        WorkbookEvaluator evaluator = new WorkbookEvaluator(null, null, null);
+        assertFalse(evaluator.isIgnoreMissingWorkbooks());
+
+        evaluator.setIgnoreMissingWorkbooks(true);
+        assertTrue(evaluator.isIgnoreMissingWorkbooks());
+
+        evaluator.setIgnoreMissingWorkbooks(false);
+        assertFalse(evaluator.isIgnoreMissingWorkbooks());
+    }
+
+    @Test
+    public void testDebugEvaluationOutputForNextEval() {
+        // TODO: update this test for meaningful functional behavior
+        WorkbookEvaluator evaluator = new WorkbookEvaluator(null, null, null);
+        assertFalse(evaluator.isDebugEvaluationOutputForNextEval());
+
+        evaluator.setDebugEvaluationOutputForNextEval(true);
+        assertTrue(evaluator.isDebugEvaluationOutputForNextEval());
+
+        evaluator.setDebugEvaluationOutputForNextEval(false);
+        assertFalse(evaluator.isDebugEvaluationOutputForNextEval());
+    }
     
 // Test IF-Equals Formula Evaluation (bug 58591)