From: Simon Brandhof <simon.brandhof@sonarsource.com>
Date: Fri, 4 Mar 2016 14:47:00 +0000 (+0100)
Subject: Fix quality flaws
X-Git-Tag: 5.5-M10~116
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=439960f954249a807ea7c11ba86466c026a84233;p=sonarqube.git

Fix quality flaws
---

diff --git a/server/sonar-server/src/main/java/org/sonar/server/ws/WebServicesWs.java b/server/sonar-server/src/main/java/org/sonar/server/ws/WebServicesWs.java
index 301214454fb..1eaaad67b08 100644
--- a/server/sonar-server/src/main/java/org/sonar/server/ws/WebServicesWs.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/ws/WebServicesWs.java
@@ -72,11 +72,11 @@ public class WebServicesWs implements WebService {
       .setDefaultValue("false");
   }
 
-  private void defineResponseExample(final Context context, NewController controller) {
+  private static void defineResponseExample(final Context context, NewController controller) {
     NewAction action = controller
       .createAction("response_example")
       .setDescription("Display web service response example")
-      .setResponseExample(getClass().getResource("response_example-example.json"))
+      .setResponseExample(WebServicesWs.class.getResource("response_example-example.json"))
       .setSince("4.4")
       .setHandler(new RequestHandler() {
         @Override
@@ -161,7 +161,7 @@ public class WebServicesWs implements WebService {
     }
   }
 
-  private void writeAction(JsonWriter writer, Action action, boolean includeInternals) {
+  private static void writeAction(JsonWriter writer, Action action, boolean includeInternals) {
     if (includeInternals || !action.isInternal()) {
       writer.beginObject();
       writer.prop("key", action.key());
diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/batch/rule/Checks.java b/sonar-plugin-api/src/main/java/org/sonar/api/batch/rule/Checks.java
index 7f021639917..c223f418a24 100644
--- a/sonar-plugin-api/src/main/java/org/sonar/api/batch/rule/Checks.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/batch/rule/Checks.java
@@ -154,7 +154,7 @@ public class Checks<C> {
     return StringUtils.defaultIfEmpty(key, clazz.getCanonicalName());
   }
 
-  private Object instantiate(ActiveRule activeRule, Object checkClassOrInstance) {
+  private static Object instantiate(ActiveRule activeRule, Object checkClassOrInstance) {
     try {
       Object check = checkClassOrInstance;
       if (check instanceof Class) {
diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/checks/AnnotationCheckFactory.java b/sonar-plugin-api/src/main/java/org/sonar/api/checks/AnnotationCheckFactory.java
index be86b62992e..397965bac4b 100644
--- a/sonar-plugin-api/src/main/java/org/sonar/api/checks/AnnotationCheckFactory.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/checks/AnnotationCheckFactory.java
@@ -74,7 +74,7 @@ public final class AnnotationCheckFactory extends CheckFactory {
     return null;
   }
 
-  private Object instantiate(ActiveRule activeRule, Object checkClassOrInstance) {
+  private static Object instantiate(ActiveRule activeRule, Object checkClassOrInstance) {
     try {
       Object check = checkClassOrInstance;
       if (check instanceof Class) {
diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/rules/AnnotationRuleParser.java b/sonar-plugin-api/src/main/java/org/sonar/api/rules/AnnotationRuleParser.java
index fd0df622783..187f835d569 100644
--- a/sonar-plugin-api/src/main/java/org/sonar/api/rules/AnnotationRuleParser.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/rules/AnnotationRuleParser.java
@@ -55,7 +55,7 @@ public final class AnnotationRuleParser {
     return rules;
   }
 
-  private Rule create(String repositoryKey, Class annotatedClass) {
+  private static Rule create(String repositoryKey, Class annotatedClass) {
     org.sonar.check.Rule ruleAnnotation = AnnotationUtils.getAnnotation(annotatedClass, org.sonar.check.Rule.class);
     if (ruleAnnotation != null) {
       return toRule(repositoryKey, annotatedClass, ruleAnnotation);