From: Nick Burch <nick@apache.org>
Date: Thu, 28 Jan 2010 12:28:29 +0000 (+0000)
Subject: Add a disabled test for bug #44501, which still remains, plus fix a generics warning
X-Git-Tag: REL_3_7_BETA1~111
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=47c7d08456779e2be5392814d4a6dc70e7a9a78e;p=poi.git

Add a disabled test for bug #44501, which still remains, plus fix a generics warning

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@904062 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/src/scratchpad/src/org/apache/poi/hdgf/chunks/Chunk.java b/src/scratchpad/src/org/apache/poi/hdgf/chunks/Chunk.java
index 595ca9ad92..fc880d5db3 100644
--- a/src/scratchpad/src/org/apache/poi/hdgf/chunks/Chunk.java
+++ b/src/scratchpad/src/org/apache/poi/hdgf/chunks/Chunk.java
@@ -116,7 +116,7 @@ public final class Chunk {
 
 		// Loop over the definitions, building the commands
 		//  and getting their values
-		ArrayList commands = new ArrayList();
+		ArrayList<Command> commands = new ArrayList<Command>();
 		for(int i=0; i<commandDefinitions.length; i++) {
 			int type = commandDefinitions[i].getType();
 			int offset = commandDefinitions[i].getOffset();
@@ -232,7 +232,7 @@ public final class Chunk {
 		}
 
 		// Save the commands we liked the look of
-		this.commands = (Command[])commands.toArray(
+		this.commands = commands.toArray(
 							new Command[commands.size()] );
 
 		// Now build up the blocks, if we had a command that tells
diff --git a/src/scratchpad/testcases/org/apache/poi/hdgf/TestHDGFCore.java b/src/scratchpad/testcases/org/apache/poi/hdgf/TestHDGFCore.java
index 67a4141768..3a571b8edc 100644
--- a/src/scratchpad/testcases/org/apache/poi/hdgf/TestHDGFCore.java
+++ b/src/scratchpad/testcases/org/apache/poi/hdgf/TestHDGFCore.java
@@ -77,4 +77,17 @@ public final class TestHDGFCore extends TestCase {
 		hdgf = new HDGFDiagram(fs);
 		assertNotNull(hdgf);
 	}
+	
+	/**
+	 * Tests that we can open a problematic file that triggers
+	 *  an ArrayIndexOutOfBoundsException when processing the
+	 *  chunk commands.
+	 * @throws Exception
+	 */
+	public void DISABLEDtestAIOOB() throws Exception {
+      fs = new POIFSFileSystem(_dgTests.openResourceAsStream("44501.vsd"));
+
+      HDGFDiagram hdgf = new HDGFDiagram(fs);
+      assertNotNull(hdgf);
+	}
 }
diff --git a/test-data/diagram/44501.vsd b/test-data/diagram/44501.vsd
new file mode 100644
index 0000000000..51de23a325
Binary files /dev/null and b/test-data/diagram/44501.vsd differ