From: Simon Brandhof <simon.brandhof@sonarsource.com>
Date: Thu, 10 May 2018 20:00:48 +0000 (+0200)
Subject: SONAR-10591 remove unused method PluginWSCommons#writeArtifact()
X-Git-Tag: 7.5~1204
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=4a9832ed492ba10904a235dbca2c4b6f1d5f75d5;p=sonarqube.git

SONAR-10591 remove unused method PluginWSCommons#writeArtifact()
---

diff --git a/server/sonar-server/src/main/java/org/sonar/server/plugins/ws/PluginWSCommons.java b/server/sonar-server/src/main/java/org/sonar/server/plugins/ws/PluginWSCommons.java
index 8cd0e1ae351..6bbad94e3b3 100644
--- a/server/sonar-server/src/main/java/org/sonar/server/plugins/ws/PluginWSCommons.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/plugins/ws/PluginWSCommons.java
@@ -158,15 +158,6 @@ public class PluginWSCommons {
     jsonWriter.endObject();
   }
 
-  public static void writeArtifact(JsonWriter jsonWriter, Release release) {
-    jsonWriter.name(OBJECT_ARTIFACT).beginObject();
-
-    jsonWriter.prop(PROPERTY_NAME, release.getFilename());
-    jsonWriter.prop(PROPERTY_URL, release.getDownloadUrl());
-
-    jsonWriter.endObject();
-  }
-
   /**
    * Write an "update" object to the specified jsonwriter.
    * <pre>
@@ -182,7 +173,7 @@ public class PluginWSCommons {
    * }
    * </pre>
    */
-  public static void writeUpdate(JsonWriter jsonWriter, PluginUpdate pluginUpdate) {
+  static void writeUpdate(JsonWriter jsonWriter, PluginUpdate pluginUpdate) {
     jsonWriter.name(OBJECT_UPDATE).beginObject();
 
     writeUpdateProperties(jsonWriter, pluginUpdate);
diff --git a/server/sonar-server/src/test/java/org/sonar/server/plugins/ws/PluginWSCommonsTest.java b/server/sonar-server/src/test/java/org/sonar/server/plugins/ws/PluginWSCommonsTest.java
index 1a622809b33..4ffd08174ad 100644
--- a/server/sonar-server/src/test/java/org/sonar/server/plugins/ws/PluginWSCommonsTest.java
+++ b/server/sonar-server/src/test/java/org/sonar/server/plugins/ws/PluginWSCommonsTest.java
@@ -192,22 +192,6 @@ public class PluginWSCommonsTest {
       "  }" +
       "}");
   }
-
-  @Test
-  public void writeArtifact_from_release_writes_artifact_object_and_file_name() {
-    jsonWriter.beginObject();
-    PluginWSCommons.writeArtifact(jsonWriter, release("pkey").setDownloadUrl("http://toto.com/file.jar"));
-    jsonWriter.endObject();
-
-    jsonWriter.close();
-    assertJson(response.outputAsString()).withStrictArrayOrder().isSimilarTo("{" +
-      "  \"artifact\": {" +
-      "     \"name\": \"file.jar\"," +
-      "     \"url\": \"http://toto.com/file.jar\"" +
-      "  }" +
-      "}");
-  }
-
   @Test
   public void status_COMPATIBLE_is_displayed_COMPATIBLE_in_JSON() {
     assertThat(toJSon(COMPATIBLE)).isEqualTo("COMPATIBLE");