From: David Gageot <david@gageot.net>
Date: Mon, 14 May 2012 13:12:08 +0000 (+0200)
Subject: SONAR-2073 - Fix which filters are visible and group them by category.
X-Git-Tag: 3.1~201
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=4db7d8befe0c7c05580daa2da7e9e7cac030b434;p=sonarqube.git

SONAR-2073 - Fix which filters are visible and group them by category.

In a filter widget you shouldn't access to a filter created by another user but not shared by this user.

Moreover, in the dropdown list to select a filter to be displayed it would be valuable to display to different sections : one for "my own filters" and the other one for the "shared filters".
---

diff --git a/sonar-server/src/main/webapp/WEB-INF/app/controllers/filters_controller.rb b/sonar-server/src/main/webapp/WEB-INF/app/controllers/filters_controller.rb
index 32f1b4a0ae2..c8764755843 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/controllers/filters_controller.rb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/controllers/filters_controller.rb
@@ -28,7 +28,7 @@ class FiltersController < ApplicationController
   before_filter :login_required, :except => ['index', 'treemap']
 
   def manage
-    @filters = ::Filter.find(:all, :conditions => ['user_id=? or user_id is null', current_user.id])
+    @filters = ::Filter.find(:all, :conditions => ['user_id=? or shared is true', current_user.id])
   end
 
   def new
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/helpers/widget_properties_helper.rb b/sonar-server/src/main/webapp/WEB-INF/app/helpers/widget_properties_helper.rb
index 165b68b22c1..cdca2e2d282 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/helpers/widget_properties_helper.rb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/helpers/widget_properties_helper.rb
@@ -37,7 +37,11 @@ module WidgetPropertiesHelper
       text_field_tag definition.key(), val, :size => 10
 
     elsif definition.type.name()==WidgetProperty::TYPE_FILTER
-      select_tag definition.key(), ::Filter.all.sort_by(&:id).collect { |f| "<option value='#{f.id}'" + (value == f.id.to_s ? " selected='selected'" : "") + ">#{f.name}</option>" }
+      user_filters = ::Filter.find(:all, :conditions => ['user_id=?', current_user.id]).sort_by(&:id).collect { |f| "<option value='#{f.id}'" + (value == f.id.to_s ? " selected='selected'" : "") + ">#{f.name}</option>" }
+      shared_filters = ::Filter.find(:all, :conditions => ['(user_id<>? or user_id is null) and shared is true', current_user.id]).sort_by(&:id).collect { |f| "<option value='#{f.id}'" + (value == f.id.to_s ? " selected='selected'" : "") + ">#{f.name}</option>" }
+      all_filters = '<optgroup label="My Filters">' + user_filters.to_s + '</optgroup>' + '<optgroup label="Shared Filters">' + shared_filters.to_s + '</optgroup>'
+
+      select_tag definition.key(), all_filters
 
     else
       hidden_field_tag definition.key()