From: Peter Smit <peter@smitmail.eu>
Date: Thu, 22 Jan 2015 13:01:45 +0000 (+0200)
Subject: Migration code: errors are not to be forgotten
X-Git-Tag: v0.9.99~1530^2^2
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=4ef32454138a40c8b3cc5334c8980e71bd431825;p=gitea.git

Migration code: errors are not to be forgotten
---

diff --git a/models/migrations/migrations.go b/models/migrations/migrations.go
index e51bc3c876..3586e5d0b6 100644
--- a/models/migrations/migrations.go
+++ b/models/migrations/migrations.go
@@ -20,7 +20,9 @@ var migrations = []migration{}
 
 // Migrate database to current version
 func Migrate(x *xorm.Engine) error {
-	x.Sync(new(Version))
+	if err := x.Sync(new(Version)); err != nil {
+		return err
+	}
 
 	currentVersion := &Version{Id: 1}
 	has, err := x.Get(currentVersion)
@@ -39,7 +41,9 @@ func Migrate(x *xorm.Engine) error {
 			return err
 		}
 		currentVersion.Version = v + int64(i) + 1
-		x.Id(1).Update(currentVersion)
+		if _, err = x.Id(1).Update(currentVersion); err != nil {
+			return err
+		}
 	}
 	return nil
 }