From: Stas Vilchik <vilchiks@gmail.com>
Date: Mon, 24 Nov 2014 09:33:24 +0000 (+0100)
Subject: SONAR-5845 Apply feedback
X-Git-Tag: 5.0-RC1~244
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=4f7037b9f3daed23140b5ab6ad629399ca2e3e9a;p=sonarqube.git

SONAR-5845 Apply feedback
---

diff --git a/server/sonar-web/src/main/coffee/issues/component-viewer/main.coffee b/server/sonar-web/src/main/coffee/issues/component-viewer/main.coffee
index 47ff206ae9e..ad050678606 100644
--- a/server/sonar-web/src/main/coffee/issues/component-viewer/main.coffee
+++ b/server/sonar-web/src/main/coffee/issues/component-viewer/main.coffee
@@ -275,7 +275,7 @@ define [
 
     scrollToLine: (line) ->
       row = @$("[data-line-number=#{line}]")
-      goal = if row.length > 0 then row.offset().top - 40 else 0
+      goal = if row.length > 0 then row.offset().top - 200 else 0
       $(window).scrollTop goal
 
 
diff --git a/server/sonar-web/src/main/hbs/issue/issue-changelog.hbs b/server/sonar-web/src/main/hbs/issue/issue-changelog.hbs
index be9c02d168a..e5f108fc4c3 100644
--- a/server/sonar-web/src/main/hbs/issue/issue-changelog.hbs
+++ b/server/sonar-web/src/main/hbs/issue/issue-changelog.hbs
@@ -2,28 +2,22 @@
   <table class="spaced">
     <tbody>
 
-    {{#if issue.author}}
-      <tr>
-        <td colspan="3">
-          {{t 'author'}}: {{issue.author}}
-        </td>
-      </tr>
-    {{/if}}
-
-    {{#if issue.reporter}}
-      <tr>
-        <td colspan="3">
-          {{t 'reporter'}}: {{default issue.reporterName issue.reporter}}
-        </td>
-      </tr>
-    {{/if}}
-
     <tr>
       <td class="thin left top" nowrap>{{dt issue.creationDate}}</td>
       <td class="thin left top" nowrap></td>
-      <td class="left top">{{t 'created'}}</td>
+      <td class="left top">
+        {{#if issue.reporter}}
+          {{t 'issue.reported_by'}} {{default issue.reporterName issue.reporter}}
+        {{else}}
+          {{#if issue.author}}
+            {{t 'created_by'}} {{issue.author}}
+          {{else}}
+            {{t 'created'}}
+          {{/if}}
+        {{/if}}
+      </td>
     </tr>
-    x§
+
     {{#each items}}
       <tr>
         <td class="thin left top" nowrap>{{dt creationDate}}</td>
diff --git a/server/sonar-web/src/main/hbs/issue/issue-rule.hbs b/server/sonar-web/src/main/hbs/issue/issue-rule.hbs
index 15b198d5203..c4f5b9c1c85 100644
--- a/server/sonar-web/src/main/hbs/issue/issue-rule.hbs
+++ b/server/sonar-web/src/main/hbs/issue/issue-rule.hbs
@@ -7,6 +7,8 @@
 
 <span class="subtitle">{{key}}</span>
 
-<div class="coding-rules-detail-description rule-desc markdown">{{{htmlDesc}}}</div>
+<div class="coding-rules-detail-description rule-desc markdown">{{{htmlDesc}}} {{{htmlDesc}}} {{{htmlDesc}}} {{{htmlDesc}}}</div>
 
-<a class="overlay-popup-close icon-close" title="{{t 'close'}}"></a>
+<div class="modal-foot">
+  <a class="overlay-popup-close" title="{{t 'close'}}">{{t 'close'}}</a>
+</div>
diff --git a/server/sonar-web/src/main/less/style.less b/server/sonar-web/src/main/less/style.less
index 5c2f8771b19..004ce649826 100644
--- a/server/sonar-web/src/main/less/style.less
+++ b/server/sonar-web/src/main/less/style.less
@@ -2792,22 +2792,27 @@ text.max-results-reached-message {
 }
 
 
-@overlayPopupMargin: 40px;
+@overlayPopupMargin: 20px;
+@overlayPopupPadding: 40px;
 
 .overlay-popup {
   position: fixed;
   z-index: 1200;
-  top: 0;
-  bottom: 0;
-  left: 0;
-  right: 0;
-  padding: @overlayPopupMargin;
+  top: @overlayPopupMargin;
+  bottom: @overlayPopupMargin;
+  left: @overlayPopupMargin;
+  right: @overlayPopupMargin;
+  padding: @overlayPopupPadding @overlayPopupPadding @overlayPopupPadding + 30px;
   background-color: #fff;
   overflow: scroll;
+  box-shadow: 0 0 20px 15px rgba(0, 0, 0, 0.5);
+
+  .modal-foot {
+    position: fixed;
+    z-index: 1201;
+    bottom: @overlayPopupMargin;
+    left: @overlayPopupMargin;
+    right: @overlayPopupMargin;
+  }
 }
 
-.overlay-popup-close {
-  position: absolute;
-  top: 8px;
-  right: 8px;
-}