From: Go MAEDA <maeda@farend.jp>
Date: Sat, 25 Mar 2023 05:09:56 +0000 (+0000)
Subject: "Cannot delete enumeration" error may occur when attempting to delete a project with... 
X-Git-Tag: 5.1.0~203
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=53f2aca3ef4976a48392367e5892caf71ac28046;p=redmine.git

"Cannot delete enumeration" error may occur when attempting to delete a project with time entries (#38286).

Patch by Holger Just and Mizuki ISHIKAWA.


git-svn-id: https://svn.redmine.org/redmine/trunk@22155 e93f8b46-1217-0410-a6f0-8f06a7374b81
---

diff --git a/app/models/project.rb b/app/models/project.rb
index 43a55428e..a50fa8807 100644
--- a/app/models/project.rb
+++ b/app/models/project.rb
@@ -30,8 +30,6 @@ class Project < ActiveRecord::Base
   # Maximum length for project identifiers
   IDENTIFIER_MAX_LENGTH = 100
 
-  # Specific overridden Activities
-  has_many :time_entry_activities, :dependent => :destroy
   has_many :memberships, :class_name => 'Member', :inverse_of => :project
   # Memberships of active users only
   has_many :members,
@@ -44,6 +42,8 @@ class Project < ActiveRecord::Base
   belongs_to :default_version, :class_name => 'Version'
   belongs_to :default_assigned_to, :class_name => 'Principal'
   has_many :time_entries, :dependent => :destroy
+  # Specific overridden Activities
+  has_many :time_entry_activities, :dependent => :destroy
   has_many :queries, :dependent => :destroy
   has_many :documents, :dependent => :destroy
   has_many :news, lambda {includes(:author)}, :dependent => :destroy
diff --git a/test/unit/project_test.rb b/test/unit/project_test.rb
index 43a3bf594..4ee1e1b36 100644
--- a/test/unit/project_test.rb
+++ b/test/unit/project_test.rb
@@ -236,6 +236,7 @@ class ProjectTest < ActiveSupport::TestCase
     # generate some dependent objects
     overridden_activity = TimeEntryActivity.new({:name => "Project", :project => @ecookbook})
     assert overridden_activity.save!
+    TimeEntry.generate!(:project => @ecookbook, :activity_id => overridden_activity.id)
 
     query = IssueQuery.generate!(:project => @ecookbook, :visibility => Query::VISIBILITY_ROLES, :roles => Role.where(:id => [1, 3]).to_a)