From: aclement <aclement>
Date: Wed, 2 Aug 2006 08:46:25 +0000 (+0000)
Subject: Fix for failure when lock()/unlock() used in XML defined pointcut and would require... 
X-Git-Tag: pre_pr_153572~26
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=572e8e4d8bf9cae92510e822c291e9bb791da683;p=aspectj.git

Fix for failure when lock()/unlock() used in XML defined pointcut and would require synchronization transform of a method
---

diff --git a/tests/src/org/aspectj/systemtest/ajc152/SynchronizationTransformTests.java b/tests/src/org/aspectj/systemtest/ajc152/SynchronizationTransformTests.java
index 75f57c8fe..ec4c1280a 100644
--- a/tests/src/org/aspectj/systemtest/ajc152/SynchronizationTransformTests.java
+++ b/tests/src/org/aspectj/systemtest/ajc152/SynchronizationTransformTests.java
@@ -174,6 +174,10 @@ public class SynchronizationTransformTests extends XMLBasedAjcTestCase {
     public void testJoinpointsEnabledButNoLock() {
     	runTest("joinpoints enabled but no lock");
     }
+    
+    public void testTransformWithLTW() {
+    	runTest("transform with LTW");
+    }
 
     // more complex code sequences...
     public void testOtherTargeters() {
diff --git a/tests/src/org/aspectj/systemtest/ajc152/synchronization.xml b/tests/src/org/aspectj/systemtest/ajc152/synchronization.xml
index d0cf6e0b2..8b4a7ed47 100644
--- a/tests/src/org/aspectj/systemtest/ajc152/synchronization.xml
+++ b/tests/src/org/aspectj/systemtest/ajc152/synchronization.xml
@@ -164,6 +164,27 @@
         </run>
     </ajc-test>
     
+    <ajc-test dir="features152/synchronization/transformed" title="transform with LTW">
+        <compile files="CaptureLock.aj" options="-1.5"/>
+        <compile files="Program.java" options="-1.5"/>
+        <run class="Program" ltw="aop1.xml">
+        	<stdout>
+        	  <line text="Before a lock or unlock"/>
+        	  <line text="hello from b()"/>
+        	  <line text="Before a lock or unlock"/>
+        	  <line text="Before a lock or unlock"/>
+        	  <line text="bang in c()"/>
+        	  <line text="Before a lock or unlock"/>
+        	  <line text="Before a lock or unlock"/>
+        	  <line text="hello from d()"/>
+        	  <line text="Before a lock or unlock"/>
+        	  <line text="hello from block in d()"/>
+        	  <line text="Before a lock or unlock"/>
+        	  <line text="Before a lock or unlock"/>
+            </stdout>
+        </run>
+    </ajc-test>
+    
     <ajc-test dir="features152/synchronization" title="using lock with LTW">
         <compile files="LockAspect1.java" options="-1.5 -Xjoinpoints:synchronization"/>
         <compile files="BasicProgram1.java" options="-1.5 -Xjoinpoints:synchronization"/>
diff --git a/weaver/src/org/aspectj/weaver/bcel/AtAjAttributes.java b/weaver/src/org/aspectj/weaver/bcel/AtAjAttributes.java
index 4e28a619e..4621fb776 100644
--- a/weaver/src/org/aspectj/weaver/bcel/AtAjAttributes.java
+++ b/weaver/src/org/aspectj/weaver/bcel/AtAjAttributes.java
@@ -1726,6 +1726,7 @@ public class AtAjAttributes {
         	PatternParser parser = new PatternParser(pointcutString, struct.context);
             Pointcut pointcut = parser.parsePointcut();
             parser.checkEof();
+            pointcut.check(null,struct.enclosingType.getWorld());
             if (!allowIf && pointcutString.indexOf("if()") >= 0 && hasIf(pointcut)) {
                 reportError("if() pointcut is not allowed at this pointcut location '" + pointcutString +"'", struct);
                 return null;