From: PJ Fanning <fanningpj@apache.org>
Date: Fri, 29 Apr 2022 12:32:54 +0000 (+0000)
Subject: small big decimal refactor
X-Git-Tag: REL_5_2_3~345
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=5dd1ded85f45078fc25d1cdafdfabfcd6dfd8f1a;p=poi.git

small big decimal refactor

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1900377 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/poi/src/main/java/org/apache/poi/ss/usermodel/DataFormatter.java b/poi/src/main/java/org/apache/poi/ss/usermodel/DataFormatter.java
index c7725d3818..89c55ad4f7 100644
--- a/poi/src/main/java/org/apache/poi/ss/usermodel/DataFormatter.java
+++ b/poi/src/main/java/org/apache/poi/ss/usermodel/DataFormatter.java
@@ -952,9 +952,8 @@ public class DataFormatter {
         }
         String formatted;
         try {
-            //see https://github.com/apache/poi/pull/321 -- but this sometimes fails as Double.toString
-            //can produce strings that can't be parsed by BigDecimal
-            formatted = numberFormat.format(new BigDecimal(Double.toString(d)));
+            //see https://github.com/apache/poi/pull/321 -- but this sometimes fails, thus the catch and retry
+            formatted = numberFormat.format(BigDecimal.valueOf(d));
         } catch (NumberFormatException nfe) {
             formatted = numberFormat.format(d);
         }