From: Peter <peter@smitmail.eu>
Date: Thu, 18 Dec 2014 11:58:18 +0000 (+0200)
Subject: Add option to use CRAM-MD5 as authentication method in the mailer
X-Git-Tag: v0.9.99~1570^2~1
X-Git-Url: https://source.dussan.org/?a=commitdiff_plain;h=5ffeca35e78544f239b73c46bf82605ec9baa3fe;p=gitea.git

Add option to use CRAM-MD5 as authentication method in the mailer
---

diff --git a/modules/mailer/mailer.go b/modules/mailer/mailer.go
index 6d75fa3f2c..daee5d76e8 100644
--- a/modules/mailer/mailer.go
+++ b/modules/mailer/mailer.go
@@ -108,14 +108,21 @@ func sendMail(settings *setting.Mailer, from string, recipients []string, msgCon
 		}
 	}
 
-	auth_available, _ := client.Extension("AUTH")
+	auth_available, options := client.Extension("AUTH")
 
-	// Possible improvement: only plain authentication is now available.
-	// Maybe in future CRAM MD5 as well?
 	if auth_available && len(settings.User) > 0 {
-		auth := smtp.PlainAuth("", settings.User, settings.Passwd, host)
-		if err = client.Auth(auth); err != nil {
-			return err
+		var auth smtp.Auth
+
+		if strings.Contains(options, "PLAIN") {
+			auth = smtp.PlainAuth("", settings.User, settings.Passwd, host)
+		} else if strings.Contains(options, "CRAM-MD5") {
+			auth = smtp.CRAMMD5Auth(settings.User, settings.Passwd)
+		}
+
+		if auth != nil {
+			if err = client.Auth(auth); err != nil {
+				return err
+			}
 		}
 	}